Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/assembler_arm32.h

Issue 1136793002: Handle ARM "ret void" and function alignment with proper padding. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: note moved to cpp Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.h ('k') | src/assembler_ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/assembler_arm32.h - Assembler for ARM32 ------*- C++ -*-===// 1 //===- subzero/src/assembler_arm32.h - Assembler for ARM32 ------*- C++ -*-===//
2 // 2 //
3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
4 // for details. All rights reserved. Use of this source code is governed by a 4 // for details. All rights reserved. Use of this source code is governed by a
5 // BSD-style license that can be found in the LICENSE file. 5 // BSD-style license that can be found in the LICENSE file.
6 // 6 //
7 // Modified by the Subzero authors. 7 // Modified by the Subzero authors.
8 // 8 //
9 //===----------------------------------------------------------------------===// 9 //===----------------------------------------------------------------------===//
10 // 10 //
(...skipping 24 matching lines...) Expand all
35 AssemblerARM32 &operator=(const AssemblerARM32 &) = delete; 35 AssemblerARM32 &operator=(const AssemblerARM32 &) = delete;
36 36
37 public: 37 public:
38 explicit AssemblerARM32(bool use_far_branches = false) : Assembler() { 38 explicit AssemblerARM32(bool use_far_branches = false) : Assembler() {
39 // This mode is only needed and implemented for MIPS and ARM. 39 // This mode is only needed and implemented for MIPS and ARM.
40 assert(!use_far_branches); 40 assert(!use_far_branches);
41 (void)use_far_branches; 41 (void)use_far_branches;
42 } 42 }
43 ~AssemblerARM32() override = default; 43 ~AssemblerARM32() override = default;
44 44
45 void alignFunction() override { 45 void alignFunction() override { llvm_unreachable("Not yet implemented."); }
46 llvm::report_fatal_error("Not yet implemented.");
47 }
48 46
49 SizeT getBundleAlignLog2Bytes() const override { return 4; } 47 SizeT getBundleAlignLog2Bytes() const override { return 4; }
50 48
49 const char *getNonExecPadDirective() const override { return ".p2alignl"; }
50
51 llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override { 51 llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override {
52 llvm::report_fatal_error("Not yet implemented."); 52 // Use a particular UDF encoding -- TRAPNaCl in LLVM: 0xE7FEDEF0
53 // http://llvm.org/viewvc/llvm-project?view=revision&revision=173943
54 static const uint8_t Padding[] = {0xE7, 0xFE, 0xDE, 0xF0};
55 return llvm::ArrayRef<uint8_t>(Padding, 4);
53 } 56 }
54 57
55 void padWithNop(intptr_t Padding) override { 58 void padWithNop(intptr_t Padding) override {
56 (void)Padding; 59 (void)Padding;
57 llvm::report_fatal_error("Not yet implemented."); 60 llvm_unreachable("Not yet implemented.");
58 } 61 }
59 62
60 void BindCfgNodeLabel(SizeT NodeNumber) override { 63 void BindCfgNodeLabel(SizeT NodeNumber) override {
61 (void)NodeNumber; 64 (void)NodeNumber;
62 llvm::report_fatal_error("Not yet implemented."); 65 llvm_unreachable("Not yet implemented.");
63 } 66 }
64 67
65 bool fixupIsPCRel(FixupKind Kind) const override { 68 bool fixupIsPCRel(FixupKind Kind) const override {
66 (void)Kind; 69 (void)Kind;
67 llvm::report_fatal_error("Not yet implemented."); 70 llvm_unreachable("Not yet implemented.");
68 } 71 }
69 }; 72 };
70 73
71 } // end of namespace ARM32 74 } // end of namespace ARM32
72 } // end of namespace Ice 75 } // end of namespace Ice
73 76
74 #endif // SUBZERO_SRC_ASSEMBLER_ARM32_H 77 #endif // SUBZERO_SRC_ASSEMBLER_ARM32_H
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/assembler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698