Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1136763003: Simplify mojo/application/public/cpp/BUILD.gn to call the target cpp instead of application. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify mojo/application/public/cpp/BUILD.gn to call the target cpp instead of application. That way other targets that depend on it don't have to specify ":application". Committed: https://crrev.com/a20d1d5f8a763eed8adbe080811e7b4777578f9d Cr-Commit-Position: refs/heads/master@{#330020}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M components/clipboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/tracing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
5 years, 7 months ago (2015-05-15 00:30:48 UTC) #2
msw
lgtm
5 years, 7 months ago (2015-05-15 00:54:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136763003/20001
5 years, 7 months ago (2015-05-15 01:03:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 02:00:24 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 02:01:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a20d1d5f8a763eed8adbe080811e7b4777578f9d
Cr-Commit-Position: refs/heads/master@{#330020}

Powered by Google App Engine
This is Rietveld 408576698