Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1136753005: Disable blink_perf.parser, crashing on the chromium.perf waterfall. (Closed)

Created:
5 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
haraken, Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable crashing blink_perf.parser perf test on Win. This test has been crashing reliably on the some GPU Bots See the attached BUG for more details. This also reverts crrev.com/1145583002 which disabled the wrong test (Adding NOTRY as everything is currently red on the perf waterfall) BUG=488493, 489294 NOTRY=true CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/0af976c456b532e4fc9cf7e6284f0af47357586d Cr-Commit-Position: refs/heads/master@{#330499}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Primiano Tucci (use gerrit)
5 years, 7 months ago (2015-05-19 09:55:09 UTC) #2
Sami
lgtm, thanks for fixing my mixup.
5 years, 7 months ago (2015-05-19 09:56:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136753005/20001
5 years, 7 months ago (2015-05-19 09:58:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 10:03:17 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0af976c456b532e4fc9cf7e6284f0af47357586d Cr-Commit-Position: refs/heads/master@{#330499}
5 years, 7 months ago (2015-05-19 10:04:12 UTC) #7
haraken
5 years, 7 months ago (2015-05-19 10:13:54 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698