Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: ios/web/web_state/web_controller_observer_bridge.h

Issue 1136753004: Use WeakNSProtocol/WeakNSObject for WebControllerObserverBridge ivars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_controller_observer_bridge.h
diff --git a/ios/web/web_state/web_controller_observer_bridge.h b/ios/web/web_state/web_controller_observer_bridge.h
index ec89d43f480ceb18d7b7d13f28ce1add35e6f20c..b1cd2f0f98ce3f227dffc3e93ba5c934ee90c00f 100644
--- a/ios/web/web_state/web_controller_observer_bridge.h
+++ b/ios/web/web_state/web_controller_observer_bridge.h
@@ -7,6 +7,7 @@
#include <string>
+#import "base/ios/weak_nsobject.h"
#include "ios/web/public/web_state/web_state_observer.h"
@class CRWWebController;
@@ -52,8 +53,8 @@ class WebControllerObserverBridge : public WebStateObserver {
const GURL& url,
bool user_is_interacting);
- id<CRWWebControllerObserver> web_controller_observer_; // Weak.
- CRWWebController* web_controller_; // Weak.
+ base::WeakNSProtocol<id<CRWWebControllerObserver>> web_controller_observer_;
+ base::WeakNSObject<CRWWebController> web_controller_;
std::string script_command_callback_prefix_;
DISALLOW_COPY_AND_ASSIGN(WebControllerObserverBridge);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698