Add android_launch_app script to allow command line options to be passed to the sampleApp when star…

Add android_launch_app script to allow command line options to be passed to the sampleApp when starting.

BUG=skia:3815
DOCS_PREVIEW= https://skia.org/?cl=1136753003
R=bungeman@google.com, tomhudson@google.com

Committed: https://skia.googlesource.com/skia/+/7c722197b3e48d28cb063df0b67a0718d8899e58

[djsollen, 2015-05-08 20:08:04]

djsollen@google.com changed reviewers:
+ bungeman@google.com, tomhudson@chromium.org

[bungeman-skia, 2015-05-08 20:24:39]

Aside from all the two space indents, lgtm.

[tomhudson, 2015-05-08 21:08:57]

tomhudson@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2015-05-08 21:08:58]

lgtm

https://codereview.chromium.org/1136753003/diff/1/platform_tools/android/app/...
File platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp (right):

https://codereview.chromium.org/1136753003/diff/1/platform_tools/android/app/...
platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp:200:
SkStrSplit(flags, " ", &flagEntries);
Worth announcing somewhere that we now need to explicitly supply --pictureDir
and --resourcePath?

I see you add them if *nothing* was provided, but if we now want to provide any
other flags we must also provide those two?

https://codereview.chromium.org/1136753003/diff/1/platform_tools/android/app/...
platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp:216: if (gWindow)
{
How could this error mode happen?

[djsollen, 2015-05-11 12:41:17]

https://codereview.chromium.org/1136753003/diff/1/platform_tools/android/app/...
File platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp (right):

https://codereview.chromium.org/1136753003/diff/1/platform_tools/android/app/...
platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp:200:
SkStrSplit(flags, " ", &flagEntries);
On 2015/05/08 21:08:57, tomhudson wrote:
> Worth announcing somewhere that we now need to explicitly supply --pictureDir
> and --resourcePath?
> 
> I see you add them if *nothing* was provided, but if we now want to provide
any
> other flags we must also provide those 

I've already updated the markdown docs.

https://codereview.chromium.org/1136753003/diff/1/platform_tools/android/app/...
platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp:216: if (gWindow)
{
On 2015/05/08 21:08:58, tomhudson wrote:
> How could this error mode happen?

Android allows views to be recreated when the app goes out of focus and then
comes back into focus.  However, we can't regenerate our window when that
happens or things like the command line parser crash as they can only be called
1x.

[tomhudson, 2015-05-11 12:48:50]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2015-05-11 12:48:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1136753003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-05-11 12:49:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136753003/20001

[commit-bot: I haz the power, 2015-05-11 12:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 12:49:11]

Presubmit check for 1136753003-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.h is missing a
correct copyright header.

[djsollen, 2015-05-11 12:54:25]

Committed patchset #2 (id:20001) manually as
7c722197b3e48d28cb063df0b67a0718d8899e58.