Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1136743003: Plumbs through screen size and scale factor to html_viewer (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumbs through screen size and scale factor to html_viewer As ResourceBundle uses the scale factor we gate loading until we know the scale factor. I also made it so ViewportMetrics::device_scale_factor is 0 until we have a real value. This way ViewManager clients have a way to know when the real value is available. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/9d3889610425bb8de984ce1393633267f438c490 Cr-Commit-Position: refs/heads/master@{#329514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -223 lines) Patch
M components/html_viewer/BUILD.gn View 4 chunks +9 lines, -4 lines 0 comments Download
M components/html_viewer/html_document.h View 5 chunks +9 lines, -7 lines 0 comments Download
M components/html_viewer/html_document.cc View 10 chunks +42 lines, -24 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 8 chunks +25 lines, -163 lines 0 comments Download
A components/html_viewer/setup.h View 1 chunk +104 lines, -0 lines 0 comments Download
A components/html_viewer/setup.cc View 1 chunk +157 lines, -0 lines 0 comments Download
M components/html_viewer/ui_setup.h View 1 chunk +5 lines, -1 line 0 comments Download
M components/html_viewer/ui_setup_android.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/html_viewer/ui_setup_android.cc View 4 chunks +17 lines, -7 lines 0 comments Download
M components/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java View 2 chunks +2 lines, -2 lines 0 comments Download
M components/native_viewport/native_viewport_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/native_viewport/native_viewport_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/native_viewport/platform_viewport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/native_viewport/platform_viewport_android.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/native_viewport/platform_viewport_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/native_viewport/platform_viewport_headless.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/native_viewport/platform_viewport_win.cc View 2 chunks +4 lines, -1 line 0 comments Download
M components/native_viewport/platform_viewport_x11.cc View 2 chunks +4 lines, -1 line 0 comments Download
M components/native_viewport/public/interfaces/native_viewport.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M components/view_manager/public/cpp/view_observer.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-12 21:50:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136743003/1
5 years, 7 months ago (2015-05-12 21:53:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 22:26:45 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 22:28:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d3889610425bb8de984ce1393633267f438c490
Cr-Commit-Position: refs/heads/master@{#329514}

Powered by Google App Engine
This is Rietveld 408576698