gpu/command_buffer/common/gles2_cmd_utils.cc - Issue 1136713003: Add ES3 commands GetVertexAttribI{u}iv to GPU command buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/common/gles2_cmd_utils.cc

Issue 1136713003: Add ES3 commands GetVertexAttribI{u}iv to GPU command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use overloading functions instead of template Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/common/gles2_cmd_ids_autogen.h ('k') | gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h » ('j') | gpu/command_buffer/service/context_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/common/gles2_cmd_utils.cc

diff --git a/gpu/command_buffer/common/gles2_cmd_utils.cc b/gpu/command_buffer/common/gles2_cmd_utils.cc

index 257758fec021a89e1ff17ca353a0eac775be5f3d..d58156f37e6cfd3469f4dc29f231f00ce4c160cd 100644

--- a/gpu/command_buffer/common/gles2_cmd_utils.cc

+++ b/gpu/command_buffer/common/gles2_cmd_utils.cc

@@ -329,7 +329,7 @@ int GLES2Util::GLGetNumValuesReturned(int id) const {

case GL_TEXTURE_MAX_ANISOTROPY_EXT:

return 1;

- // -- glGetVertexAttribfv, glGetVertexAttribiv

+ // -- glGetVertexAttrib

case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING:

return 1;

case GL_VERTEX_ATTRIB_ARRAY_ENABLED:

@@ -344,6 +344,10 @@ int GLES2Util::GLGetNumValuesReturned(int id) const {

return 1;

case GL_CURRENT_VERTEX_ATTRIB:

return 4;

+ case GL_VERTEX_ATTRIB_ARRAY_INTEGER:

+ return 1;

+ case GL_VERTEX_ATTRIB_ARRAY_DIVISOR:

+ return 1;

// -- glGetSynciv

case GL_OBJECT_TYPE: