Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 11367099: Merge 166023 - Ensure sidebar links are re-enabled when a confirmation dialog is closed (Closed)

Created:
8 years, 1 month ago by bartfab (slow)
Modified:
8 years, 1 month ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Merge 166023 - Ensure sidebar links are re-enabled when a confirmation dialog is closed Confirmation dialogs should have the BrowserOptions page as their parent. If they do not, closing a confirmation dialog will not re-enable the sidebar links (History/Extensions/Settings/Help). The parent used to be set correctly but got lost accidentally in the refactor of crrev.com/163874. BUG=158912 Review URL: https://codereview.chromium.org/11366083 TBR=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M chrome/browser/resources/options/options.js View 1 chunk +32 lines, -26 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bartfab (slow)
8 years, 1 month ago (2012-11-05 20:44:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698