cc: Remove all remaining use of WebCore Rect/Point/Size types from the compositor.

cc: Remove all remaining use of WebCore Rect/Point/Size types from the compositor.

This change removes all IntPoint/FloatRect/IntSize/etc from the compositor.
There remains an indirect dependency on these types through the
WebCore::Region class, which we wrap but need to replace. However, the wrapper
there hides the WebCore types inside it, so there are now no references to the
types from anywhere else in the compositor.

I went back and forth on how to deal with scroll "positions". The name suggested
that they should be Points, and that the deltas should be Vectors. However this
lent itself to super awkward math at times. In the end, it was much cleaner to
make all scroll "positions" into scroll "offsets" and represent everything as
Vectors.

Covered by existing tests; no change in behaviour.

R=enne
BUG=147395
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165947

[danakj, 2012-11-03 03:39:25]

dun dun dun..

[danakj, 2012-11-03 03:39:49]

+aelias please take a look as well.

[enne (OOO), 2012-11-03 03:54:18]

dun dun dun, indeed!

lgtm

https://codereview.chromium.org/11367080/diff/1059/cc/proxy.h
File cc/proxy.h (right):

https://codereview.chromium.org/11367080/diff/1059/cc/proxy.h#newcode43
cc/proxy.h:43: virtual void startPageScaleAnimation(gfx::Vector2d targetOffet,
bool useAnchor, float scale, base::TimeDelta duration) = 0;
Typo.

[danakj, 2012-11-03 13:45:04]

Thanks, nice catch.

https://codereview.chromium.org/11367080/diff/1059/cc/proxy.h
File cc/proxy.h (right):

https://codereview.chromium.org/11367080/diff/1059/cc/proxy.h#newcode43
cc/proxy.h:43: virtual void startPageScaleAnimation(gfx::Vector2d targetOffet,
bool useAnchor, float scale, base::TimeDelta duration) = 0;
On 2012/11/03 03:54:18, enne wrote:
> Typo.

Done.