Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 11367061: cc: Remove some entries from DEPS list. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
danakj, jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Remove some entries from DEPS list. This appears to have been fixed in past revisions so we can remove them now. TEST=run checkdeps.py, it should succeed. R=enne@chromium.org,jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165758

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M cc/DEPS View 2 chunks +0 lines, -7 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
8 years, 1 month ago (2012-11-02 16:04:36 UTC) #1
danakj
http://codereview.chromium.org/11367061/diff/1/cc/DEPS File cc/DEPS (left): http://codereview.chromium.org/11367061/diff/1/cc/DEPS#oldcode25 cc/DEPS:25: "+third_party/WebKit/Source/WTF/config.h", These are still in stubs/config.h, I think they ...
8 years, 1 month ago (2012-11-02 16:11:37 UTC) #2
tfarina
http://codereview.chromium.org/11367061/diff/1/cc/DEPS File cc/DEPS (left): http://codereview.chromium.org/11367061/diff/1/cc/DEPS#oldcode25 cc/DEPS:25: "+third_party/WebKit/Source/WTF/config.h", On 2012/11/02 16:11:37, danakj wrote: > These are ...
8 years, 1 month ago (2012-11-02 16:26:28 UTC) #3
danakj
lgtm http://codereview.chromium.org/11367061/diff/1/cc/DEPS File cc/DEPS (left): http://codereview.chromium.org/11367061/diff/1/cc/DEPS#oldcode25 cc/DEPS:25: "+third_party/WebKit/Source/WTF/config.h", On 2012/11/02 16:26:28, tfarina wrote: > On ...
8 years, 1 month ago (2012-11-02 16:48:51 UTC) #4
enne (OOO)
8 years, 1 month ago (2012-11-02 17:04:23 UTC) #5
lgtm2

Powered by Google App Engine
This is Rietveld 408576698