Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 11367059: Merge 132904 - [subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap (Closed)

Created:
8 years, 1 month ago by eae
Modified:
7 years, 8 months ago
Reviewers:
eae
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 132904 - [subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap https://bugs.webkit.org/show_bug.cgi?id=100742 Reviewed by Levi Weintraub. Source/WebCore: As we no longer pixel snap values when computing the current width for a line we should not do it in shrinkAvailableWidthForNewFloatIfNeeded either. Test: fast/sub-pixel/float-wrap-zoom.html * rendering/RenderBlockLineLayout.cpp: (WebCore::LineWidth::LineWidth): Remove unnecessary ifdef. (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Use float values instead of pixel snapped/floored values as the line width calculations uses floats. LayoutTests: Add test for wrapping when combining float and inline elements. * fast/sub-pixel/float-wrap-zoom-expected.html: Added. * fast/sub-pixel/float-wrap-zoom.html: Added. TBR=eae@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
A + LayoutTests/fast/sub-pixel/float-wrap-zoom.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/sub-pixel/float-wrap-zoom-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderBlockLineLayout.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
eae
8 years, 1 month ago (2012-11-02 14:32:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698