samples/clock/clock.dart - Issue 11367040: Removing Element.rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/clock/clock.dart

Issue 11367040: Removing Element.rect. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/clock/clock.dart

diff --git a/samples/clock/clock.dart b/samples/clock/clock.dart

index c8fc17c021cd3c7e62524623fb9c1c0e757ec9ad..36ec1701c0af6f753a35ef64c97c3b53b7908008 100644

--- a/samples/clock/clock.dart

+++ b/samples/clock/clock.dart

@@ -48,8 +48,8 @@ class CountDownClock {

balls = new Balls() {

var parent = query("#canvas-content");

Jacob 2012/11/02 05:00:29 remove requestLayoutFrame as well as async getComp

blois 2012/11/02 20:04:46 Not sure which getComputedStyles you're referring

- parent.rect.then((ElementRect r) {

- createNumbers(parent, r.client.width, r.client.height);

+ window.requestLayoutFrame(() {

+ createNumbers(parent, parent.clientWidth, parent.clientHeight);

updateTime(new Date.now());

« no previous file with comments | « samples/calculator/tape.dart ('k') | samples/clock/numbers.dart » ('j') | no next file with comments »