Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Issue 1136693003: TurboFan: commit dependencies only on update of the opt. code list. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

TurboFan: commit dependencies only on update of the opt. code list. TurboFan compilation was committing dependencies long before the optimized function made it's way into the optimized code list for the native context. The problem is that once the code pointer is out there in dependency arrays, it is eligible for deopt. But the deopt logic needs the code to be in the optimized code list to fully do it's job. BUG= R=jarin@chromium.org Committed: https://crrev.com/f9c46ed1bbaa925fc4001a7e310100420df8808a Cr-Commit-Position: refs/heads/master@{#28312}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed errant printf. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/compiler.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mvstanton
Hi Jaro, here is the issue we discussed, thx! --Michael
5 years, 7 months ago (2015-05-08 08:29:14 UTC) #1
Jarin
lgtm with a nit. https://codereview.chromium.org/1136693003/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1136693003/diff/1/src/deoptimizer.cc#newcode500 src/deoptimizer.cc:500: ThreadId::Current().ToInteger(), reinterpret_cast<void*>(code)); This PrintF should ...
5 years, 7 months ago (2015-05-08 08:34:16 UTC) #2
mvstanton
doh! Thanks Jaro :) --Michael
5 years, 7 months ago (2015-05-08 08:47:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136693003/20001
5 years, 7 months ago (2015-05-08 08:50:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-08 09:13:17 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 09:13:29 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9c46ed1bbaa925fc4001a7e310100420df8808a
Cr-Commit-Position: refs/heads/master@{#28312}

Powered by Google App Engine
This is Rietveld 408576698