Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3588)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.h

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments before LGTM Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.h
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.h b/chrome/browser/ui/views/profiles/profile_chooser_view.h
index d9b59812d1169b414a1797ffc4ee645fc86132d6..c5b96f5bbeefeed3b13ece25f23cf160eab18469 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.h
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.h
@@ -62,6 +62,15 @@ class ProfileChooserView : public content::WebContentsDelegate,
views::BubbleBorder::BubbleAlignment border_alignment,
Browser* browser);
static bool IsShowing();
+
+ // A ShowingType to indicate whether the avatar bubble view is showing in
+ // designate browser.
msw 2015/05/19 22:57:48 nit: designated
gogerald1 2015/05/19 23:35:13 Done.
+ enum ShowingType {
+ IS_NOT_SHOWING = 0,
+ IS_SHOWING = 1,
msw 2015/05/19 22:57:49 nit: explicit assignment of consecutive values isn
gogerald1 2015/05/19 23:35:13 Yes, but list to make them obvious, On 2015/05/19
+ IS_SHOWING_IN_ANOTHER_BROWSER = 2,
+ };
+ static ShowingType IsShowingInBrowser(const Browser* browser);
static void Hide();
private:

Powered by Google App Engine
This is Rietveld 408576698