chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm - Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address roger's comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/avatar_base_controller.h ('k') | chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm » ('j') | chrome/browser/ui/views/profiles/new_avatar_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

index a841a94f7fe97f38e476ce2db2c80be6e395786b..a5f9f2515ac4d259a7ddc3c7b441e9852499cb67 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

@@ -218,6 +218,11 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver,

ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ICON_AVATAR_BUBBLE);

}

+- (void)closeAvatarBubble {

+ if (menuController_ != nil)

groby-ooo-7-16 2015/05/15 16:16:24 nit: No need to check - you can send messages to n

gogerald1 2015/05/19 23:35:12 Done.

+ [menuController_ close];

- (IBAction)buttonClicked:(id)sender {

BrowserWindow::AvatarBubbleMode mode =

BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT;