Chrome user menu shouldn't close if a tab steals focus

chrome/browser/ui/views/profiles/new_avatar_button.cc

Index: chrome/browser/ui/views/profiles/new_avatar_button.cc
diff --git a/chrome/browser/ui/views/profiles/new_avatar_button.cc b/chrome/browser/ui/views/profiles/new_avatar_button.cc
index 0fa981f6ef08fb36f9c2566b4ac52aaac0c5089a..341b23e7866afe49d6ee1f9bee717e8567ff82d5 100644
--- a/chrome/browser/ui/views/profiles/new_avatar_button.cc
+++ b/chrome/browser/ui/views/profiles/new_avatar_button.cc
@@ -48,8 +48,7 @@ NewAvatarButton::NewAvatarButton(views::ButtonListener* listener,
                                  Browser* browser)
     : LabelButton(listener, base::string16()),
       browser_(browser),
-      has_auth_error_(false),
-      suppress_mouse_released_action_(false) {
+      has_auth_error_(false) {
   set_triggerable_event_flags(
       ui::EF_LEFT_MOUSE_BUTTON | ui::EF_RIGHT_MOUSE_BUTTON);
   set_animate_on_state_change(false);
@@ -120,15 +119,12 @@ NewAvatarButton::~NewAvatarButton() {
 }
 
 bool NewAvatarButton::OnMousePressed(const ui::MouseEvent& event) {
-  // Prevent the bubble from being re-shown if it's already showing.
-  suppress_mouse_released_action_ = ProfileChooserView::IsShowing();
+  if (ProfileChooserView::IsShowing())
+    ProfileChooserView::Hide();
   return LabelButton::OnMousePressed(event);
 }
 
 void NewAvatarButton::OnMouseReleased(const ui::MouseEvent& event) {
-  if (suppress_mouse_released_action_)
-    suppress_mouse_released_action_ = false;
-  else

[Roger Tawa OOO till Jul 10th, 2015/05/14 18:55:03]

This change makes it so that clicking a second time on the same avatar button
causes the popup to close and reopen.  We should maintain the old behaviour
which was to close the popup.

[gogerald1, 2015/05/14 21:35:22]

Done.

     LabelButton::OnMouseReleased(event);
 }