chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Michael's nit comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 5a70b3940eb34aa55558cbb459fa827e4839395a..edf2af8cb7c9e8bf43040e392cbc2d3949ddb745 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -803,6 +803,10 @@ void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(

withServiceType:manage_accounts_params.service_type];

}

+void BrowserWindowCocoa::CloseAvatarBubbleFromAvatarButton() {

+ [[controller_ avatarButtonController] closeAvatarBubble];

int

BrowserWindowCocoa::GetRenderViewHeightInsetWithDetachedBookmarkBar() {

if (browser_->bookmark_bar_state() != BookmarkBar::DETACHED)

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('j') | no next file with comments »