chrome/browser/ui/views/profiles/profile_chooser_view.h - Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.h

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address msw's comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/profiles/new_avatar_button.cc ('K') | « chrome/browser/ui/views/profiles/new_avatar_button.cc ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/profile_chooser_view.h

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.h b/chrome/browser/ui/views/profiles/profile_chooser_view.h

index d9b59812d1169b414a1797ffc4ee645fc86132d6..c1ecd80ae9789f25b1cee27af180438a81e19577 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view.h

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.h

@@ -62,6 +62,15 @@ class ProfileChooserView : public content::WebContentsDelegate,

views::BubbleBorder::BubbleAlignment border_alignment,

Browser* browser);

static bool IsShowing();

+ // A ShowingType to indicate whether the avatar bubble view is showing in

+ // designated browser.

msw 2015/05/20 00:18:12 nit: sorry, grammatically, this should be "in a de

gogerald1 2015/05/20 14:06:24 Done.

+ enum ShowingType {

+ IS_NOT_SHOWING = 0,

+ IS_SHOWING = 1,

+ IS_SHOWING_IN_ANOTHER_BROWSER = 2,

+ };

+ static ShowingType IsShowingInBrowser(const Browser* browser);

static void Hide();

private: