Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Chrome user menu shouldn't close if a tab steals focus Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/browser/browser_process.h" 12 #include "chrome/browser/browser_process.h"
13 #include "chrome/browser/extensions/signin/gaia_auth_extension_loader.h" 13 #include "chrome/browser/extensions/signin/gaia_auth_extension_loader.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/signin/signin_promo.h" 15 #include "chrome/browser/signin/signin_promo.h"
16 #include "chrome/browser/ui/browser_finder.h"
16 #include "chrome/browser/ui/browser_navigator.h" 17 #include "chrome/browser/ui/browser_navigator.h"
18 #include "chrome/browser/ui/browser_window.h"
17 #include "chrome/common/pref_names.h" 19 #include "chrome/common/pref_names.h"
20 #include "components/signin/core/common/profile_management_switches.h"
18 #include "content/public/browser/web_contents.h" 21 #include "content/public/browser/web_contents.h"
19 #include "content/public/browser/web_ui.h" 22 #include "content/public/browser/web_ui.h"
20 #include "google_apis/gaia/gaia_urls.h" 23 #include "google_apis/gaia/gaia_urls.h"
21 #include "net/base/url_util.h" 24 #include "net/base/url_util.h"
25 #include "ui/aura/window.h"
22 26
23 InlineLoginHandler::InlineLoginHandler() {} 27 InlineLoginHandler::InlineLoginHandler() {}
24 28
25 InlineLoginHandler::~InlineLoginHandler() {} 29 InlineLoginHandler::~InlineLoginHandler() {}
26 30
27 void InlineLoginHandler::RegisterMessages() { 31 void InlineLoginHandler::RegisterMessages() {
28 web_ui()->RegisterMessageCallback("initialize", 32 web_ui()->RegisterMessageCallback("initialize",
29 base::Bind(&InlineLoginHandler::HandleInitializeMessage, 33 base::Bind(&InlineLoginHandler::HandleInitializeMessage,
30 base::Unretained(this))); 34 base::Unretained(this)));
31 web_ui()->RegisterMessageCallback("completeLogin", 35 web_ui()->RegisterMessageCallback("completeLogin",
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 main_frame_url = net::AppendOrReplaceQueryParameter( 133 main_frame_url = net::AppendOrReplaceQueryParameter(
130 main_frame_url, signin::kSignInPromoQueryKeyShowAccountManagement, "1"); 134 main_frame_url, signin::kSignInPromoQueryKeyShowAccountManagement, "1");
131 135
132 chrome::NavigateParams params( 136 chrome::NavigateParams params(
133 profile, 137 profile,
134 net::AppendOrReplaceQueryParameter( 138 net::AppendOrReplaceQueryParameter(
135 main_frame_url, signin::kSignInPromoQueryKeyConstrained, "0"), 139 main_frame_url, signin::kSignInPromoQueryKeyConstrained, "0"),
136 ui::PAGE_TRANSITION_AUTO_TOPLEVEL); 140 ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
137 chrome::Navigate(&params); 141 chrome::Navigate(&params);
138 142
143 signin_metrics::Source source_ = signin::GetSourceForPromoURL(main_frame_url);
144 if (source_ == signin_metrics::SOURCE_AVATAR_BUBBLE_SIGN_IN ||
145 source_ == signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT) {
146 Browser* browser = chrome::FindAnyBrowser(
147 profile, false,
148 chrome::GetHostDesktopTypeForNativeView(web_contents->GetNativeView()));
149 if (browser != nullptr) {
150 browser->window()->CloseAvatarBubbleFromAvatarButton();
151 }
Roger Tawa OOO till Jul 10th 2015/05/14 18:55:03 Nit: don't need { and } for this simple if stateme
gogerald1 2015/05/14 21:35:22 Done.
152 }
153
139 web_ui()->CallJavascriptFunction("inline.login.closeDialog"); 154 web_ui()->CallJavascriptFunction("inline.login.closeDialog");
140 } 155 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698