Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Michael's nit comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 const content::NativeWebKeyboardEvent& event) override; 346 const content::NativeWebKeyboardEvent& event) override;
347 void CutCopyPaste(int command_id) override; 347 void CutCopyPaste(int command_id) override;
348 WindowOpenDisposition GetDispositionForPopupBounds( 348 WindowOpenDisposition GetDispositionForPopupBounds(
349 const gfx::Rect& bounds) override; 349 const gfx::Rect& bounds) override;
350 FindBar* CreateFindBar() override; 350 FindBar* CreateFindBar() override;
351 web_modal::WebContentsModalDialogHost* GetWebContentsModalDialogHost() 351 web_modal::WebContentsModalDialogHost* GetWebContentsModalDialogHost()
352 override; 352 override;
353 void ShowAvatarBubbleFromAvatarButton( 353 void ShowAvatarBubbleFromAvatarButton(
354 AvatarBubbleMode mode, 354 AvatarBubbleMode mode,
355 const signin::ManageAccountsParams& manage_accounts_params) override; 355 const signin::ManageAccountsParams& manage_accounts_params) override;
356 void CloseAvatarBubbleFromAvatarButton() override;
356 int GetRenderViewHeightInsetWithDetachedBookmarkBar() override; 357 int GetRenderViewHeightInsetWithDetachedBookmarkBar() override;
357 void ExecuteExtensionCommand(const extensions::Extension* extension, 358 void ExecuteExtensionCommand(const extensions::Extension* extension,
358 const extensions::Command& command) override; 359 const extensions::Command& command) override;
359 ExclusiveAccessContext* GetExclusiveAccessContext() override; 360 ExclusiveAccessContext* GetExclusiveAccessContext() override;
360 361
361 BookmarkBarView* GetBookmarkBarView() const; 362 BookmarkBarView* GetBookmarkBarView() const;
362 LocationBarView* GetLocationBarView() const; 363 LocationBarView* GetLocationBarView() const;
363 views::View* GetTabContentsContainerView() const; 364 views::View* GetTabContentsContainerView() const;
364 ToolbarView* GetToolbarView() const; 365 ToolbarView* GetToolbarView() const;
365 366
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 scoped_ptr<ImmersiveModeController> immersive_mode_controller_; 700 scoped_ptr<ImmersiveModeController> immersive_mode_controller_;
700 701
701 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_; 702 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_;
702 703
703 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_; 704 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
704 705
705 DISALLOW_COPY_AND_ASSIGN(BrowserView); 706 DISALLOW_COPY_AND_ASSIGN(BrowserView);
706 }; 707 };
707 708
708 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 709 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698