chrome/browser/ui/cocoa/profiles/avatar_base_controller.h - Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.h

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Michael's nit comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BASE_CONTROLLER_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BASE_CONTROLLER_H_

6 #define CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BASE_CONTROLLER_H_	6 #define CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BASE_CONTROLLER_H_

7	7

8 #import <AppKit/AppKit.h>	8 #import <AppKit/AppKit.h>

9	9

10 #import "base/mac/scoped_nsobject.h"	10 #import "base/mac/scoped_nsobject.h"

(...skipping 26 matching lines...) Expand all Loading...
37 @property(readonly, nonatomic) NSButton* buttonView;	37 @property(readonly, nonatomic) NSButton* buttonView;

38	38

39 // Designated initializer.	39 // Designated initializer.

40 - (id)initWithBrowser:(Browser*)browser;	40 - (id)initWithBrowser:(Browser*)browser;

41	41

42 // Shows the avatar bubble in the given mode.	42 // Shows the avatar bubble in the given mode.

43 - (void)showAvatarBubbleAnchoredAt:(NSView*)anchor	43 - (void)showAvatarBubbleAnchoredAt:(NSView*)anchor

44 withMode:(BrowserWindow::AvatarBubbleMode)mode	44 withMode:(BrowserWindow::AvatarBubbleMode)mode

45 withServiceType:(signin::GAIAServiceType)serviceType;	45 withServiceType:(signin::GAIAServiceType)serviceType;

46	46

	47 - (void)closeAvatarBubble;

47 @end	48 @end

48	49

49 @interface AvatarBaseController (ExposedForTesting)	50 @interface AvatarBaseController (ExposedForTesting)

50 - (BaseBubbleController*)menuController;	51 - (BaseBubbleController*)menuController;

51 @end	52 @end

52	53

53 #endif // CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BASE_CONTROLLER_H_	54 #endif // CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BASE_CONTROLLER_H_

OLD	NEW