Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Michael's nit comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "chrome/browser/lifetime/browser_close_manager.h" 9 #include "chrome/browser/lifetime/browser_close_manager.h"
10 #include "chrome/browser/signin/signin_header_helper.h" 10 #include "chrome/browser/signin/signin_header_helper.h"
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 AVATAR_BUBBLE_MODE_SIGNIN, 371 AVATAR_BUBBLE_MODE_SIGNIN,
372 AVATAR_BUBBLE_MODE_ADD_ACCOUNT, 372 AVATAR_BUBBLE_MODE_ADD_ACCOUNT,
373 AVATAR_BUBBLE_MODE_REAUTH, 373 AVATAR_BUBBLE_MODE_REAUTH,
374 AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN, 374 AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN,
375 AVATAR_BUBBLE_MODE_SHOW_ERROR, 375 AVATAR_BUBBLE_MODE_SHOW_ERROR,
376 AVATAR_BUBBLE_MODE_FAST_USER_SWITCH, 376 AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
377 }; 377 };
378 virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode, 378 virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode,
379 const signin::ManageAccountsParams& manage_accounts_params) = 0; 379 const signin::ManageAccountsParams& manage_accounts_params) = 0;
380 380
381 // Closes the avatar bubble on the window frame.
382 virtual void CloseAvatarBubbleFromAvatarButton() = 0;
383
381 // Returns the height inset for RenderView when detached bookmark bar is 384 // Returns the height inset for RenderView when detached bookmark bar is
382 // shown. Invoked when a new RenderHostView is created for a non-NTP 385 // shown. Invoked when a new RenderHostView is created for a non-NTP
383 // navigation entry and the bookmark bar is detached. 386 // navigation entry and the bookmark bar is detached.
384 virtual int GetRenderViewHeightInsetWithDetachedBookmarkBar() = 0; 387 virtual int GetRenderViewHeightInsetWithDetachedBookmarkBar() = 0;
385 388
386 // Executes |command| registered by |extension|. 389 // Executes |command| registered by |extension|.
387 virtual void ExecuteExtensionCommand(const extensions::Extension* extension, 390 virtual void ExecuteExtensionCommand(const extensions::Extension* extension,
388 const extensions::Command& command) = 0; 391 const extensions::Command& command) = 0;
389 392
390 // Returns object implementing ExclusiveAccessContext interface. 393 // Returns object implementing ExclusiveAccessContext interface.
391 virtual ExclusiveAccessContext* GetExclusiveAccessContext() = 0; 394 virtual ExclusiveAccessContext* GetExclusiveAccessContext() = 0;
392 395
393 protected: 396 protected:
394 friend class BrowserCloseManager; 397 friend class BrowserCloseManager;
395 friend class BrowserView; 398 friend class BrowserView;
396 virtual void DestroyBrowser() = 0; 399 virtual void DestroyBrowser() = 0;
397 }; 400 };
398 401
399 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 402 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698