Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136673005: Merge to XFA: Add safe FX_Alloc2D() macro (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -56 lines) Patch
M core/include/fxcrt/fx_basic.h View 1 chunk +1 line, -4 lines 0 comments Download
M core/include/fxcrt/fx_memory.h View 2 chunks +9 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxcrt/fx_basic_memmgr_unittest.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M core/src/fxge/agg/agg23/fx_agg_path_storage.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR
5 years, 7 months ago (2015-05-18 21:24:51 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 038cd084817aca8017255a6b3782fcba2688d2cb (presubmit successful).
5 years, 7 months ago (2015-05-18 21:29:28 UTC) #2
Lei Zhang
5 years, 7 months ago (2015-05-18 21:42:56 UTC) #3
Message was sent while issue was closed. 
lgtm

Maybe make a pass through the XFA branch and looks for branch specific places
where FX_Alloc2D() can be applied?

Powered by Google App Engine
This is Rietveld 408576698