Issue 1136673004: Moterm part 5: Add moterm itself.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1136673004: Moterm part 5: Add moterm itself. (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Moterm part 5: Add moterm itself. This is not the last part. moterm itself is an embeddable view that provides services to whatever's embedding it. (I.e., whoever embeds it gets to decide who/what moterm is connected to.) As such, mojo:moterm as a standalone app is very boring (it doesn't really do anything). Thus the next (?) part will have an app that embeds it and does something. Also, I have to figure out the best way to test this sort of thing. Sadly, there's no obvious precedent that I can cargo-cult from. There are also various features it could use (e.g., pixel density awareness, settable font size -- probably exposed to its embedder). R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2f9c429a3cf95540d2ec7602bcc690298ed7d658

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+551 lines, -16 lines)			Patch
M	apps/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	apps/moterm/BUILD.gn	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A +	apps/moterm/moterm_main.cc	View	3 chunks	+24 lines, -16 lines	0 comments	Download
A	apps/moterm/moterm_view.h	View	1 chunk	+120 lines, -0 lines	0 comments	Download
A	apps/moterm/moterm_view.cc	View	1 chunk	+338 lines, -0 lines	0 comments	Download
M	mojo/services/terminal/public/interfaces/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	mojo/services/terminal/public/interfaces/terminal.mojom	View	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 7 months ago (2015-05-11 23:10:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f9c429a3cf95540d2ec7602bcc690298ed7d658 (presubmit successful).

Expand Messages | Collapse Messages