Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1136673003: Revert of [Chromoting] Add GN build support for ar_sample_app target. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, Jamie, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Add GN build support for ar_sample_app target. (patchset #1 id:1 of https://codereview.chromium.org/1135933002/) Reason for revert: Broke GN bots, eg.: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28281 Original issue's description: > [Chromoting] Add GN build support for ar_sample_app target. > > This adds GN build rules for the AppRemoting sample app. > Some DesktopRemoting build rules were prettified as part of this > process (to make the App- and Desktop- remoting build rules more > similar). > > This re-lands crrev.com/1126393002 without any additional changes > required. The issues with the GN clobber builds are fixed in > crrev.com/1137753002. > > BUG=471916 > > Committed: https://crrev.com/581797d8f76d5855b7f0bed1fe912a038d1d7d25 > Cr-Commit-Position: refs/heads/master@{#329206} TBR=jamiewalch@chromium.org,garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471916 Committed: https://crrev.com/0374f266283d285a5a5925d43c4f07074e3a5b65 Cr-Commit-Position: refs/heads/master@{#329228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -450 lines) Patch
M remoting/app_remoting_webapp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/app_remoting_webapp_build.gypi View 2 chunks +1 line, -1 line 0 comments Download
M remoting/remoting_client.gypi View 6 chunks +4 lines, -4 lines 0 comments Download
M remoting/remoting_version.gni View 7 chunks +7 lines, -7 lines 0 comments Download
M remoting/webapp/BUILD.gn View 3 chunks +93 lines, -15 lines 0 comments Download
M remoting/webapp/build-webapp.py View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/build_template.gni View 5 chunks +26 lines, -304 lines 0 comments Download
M remoting/webapp/files.gni View 6 chunks +5 lines, -117 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
msw
Created Revert of [Chromoting] Add GN build support for ar_sample_app target.
5 years, 7 months ago (2015-05-11 20:21:26 UTC) #1
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-11 20:21:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136673003/1
5 years, 7 months ago (2015-05-11 20:22:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 20:23:55 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 20:24:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0374f266283d285a5a5925d43c4f07074e3a5b65
Cr-Commit-Position: refs/heads/master@{#329228}

Powered by Google App Engine
This is Rietveld 408576698