Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1136663005: Implement %TypedArray%.{fill,find,findIndex} (Closed)

Created:
5 years, 7 months ago by dehrenberg
Modified:
5 years, 7 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement %TypedArray%.{fill,find,findIndex} This patch adds three methods to TypedArrays which are already implemented for arrays. The implementations are made by calling out to the underlying code used by Arrays. R=adamk@chromium.org BUG=v8:3578 LOG=Y Committed: https://crrev.com/b57428e9efe2b07656e5d78fbcfb2d4ba62bb86b Cr-Commit-Position: refs/heads/master@{#28382}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moving declarations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -37 lines) Patch
M src/harmony-array.js View 1 6 chunks +37 lines, -36 lines 0 comments Download
M src/harmony-typedarray.js View 2 chunks +35 lines, -1 line 0 comments Download
A test/mjsunit/harmony/typedarray-fill.js View 1 chunk +39 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typedarray-find.js View 1 chunk +179 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typedarray-findindex.js View 1 chunk +179 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dehrenberg
5 years, 7 months ago (2015-05-12 23:09:17 UTC) #1
adamk
lgtm % nits https://codereview.chromium.org/1136663005/diff/1/src/harmony-array.js File src/harmony-array.js (right): https://codereview.chromium.org/1136663005/diff/1/src/harmony-array.js#newcode151 src/harmony-array.js:151: %FunctionSetLength(ArrayFindIndex, 1); Please move this down ...
5 years, 7 months ago (2015-05-12 23:18:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136663005/20001
5 years, 7 months ago (2015-05-12 23:53:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 04:32:18 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 04:32:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b57428e9efe2b07656e5d78fbcfb2d4ba62bb86b
Cr-Commit-Position: refs/heads/master@{#28382}

Powered by Google App Engine
This is Rietveld 408576698