Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136663004: Ensure the new navigation classifier works in the real world. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure the new navigation classifier works in the real world. BUG=369661 TEST=No whammies! Committed: https://crrev.com/f97970c11c08a18e9ecea0b1b4c77122371a0e4f Cr-Commit-Position: refs/heads/master@{#329497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Avi (use Gerrit)
5 years, 7 months ago (2015-05-12 19:59:45 UTC) #2
Charlie Reis
LGTM
5 years, 7 months ago (2015-05-12 20:15:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136663004/1
5 years, 7 months ago (2015-05-12 20:16:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 21:36:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f97970c11c08a18e9ecea0b1b4c77122371a0e4f Cr-Commit-Position: refs/heads/master@{#329497}
5 years, 7 months ago (2015-05-12 21:38:41 UTC) #7
Avi (use Gerrit)
5 years, 7 months ago (2015-05-14 14:58:39 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1140123002/ by avi@chromium.org.

The reason for reverting is: Occasional crashes..

Powered by Google App Engine
This is Rietveld 408576698