Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: build/android/tests/bad_resources/bad_resources.gyp

Issue 1136653002: Reland: Actually use --extra-r-text-files in process_resources.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle APKs with no resources and add a --include-all-resources option Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/tests/bad_resources/bad_resources.gyp
diff --git a/build/android/tests/bad_resources/bad_resources.gyp b/build/android/tests/bad_resources/bad_resources.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..07d3bf229f67e59a5566efda602245fd33c4c6a2
--- /dev/null
+++ b/build/android/tests/bad_resources/bad_resources.gyp
@@ -0,0 +1,50 @@
+# Copyright (c) 2015 The Chromium Authors. All rights reserved.
gunsch 2015/05/08 17:48:14 nit: no (c)
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
gunsch 2015/05/08 17:48:13 nit: blank line above
+ 'variables': {
+ 'chromium_code': 1,
+ },
+ 'targets': [
+ {
+ 'target_name': 'empty_resources_dep',
+ 'type': 'none',
+ 'variables': {
+ 'java_in_dir': 'empty_dep/java',
+ 'has_java_resources': 1,
+ 'R_package': 'dummy.emptydep',
+ 'R_package_relpath': 'dummy/emptydep',
+ },
+ 'includes': [ '../../../../build/java.gypi' ],
+ },
+ {
+ 'target_name': 'bad_resources_dep',
+ 'type': 'none',
+ 'variables': {
+ 'java_in_dir': 'dep/java',
+ 'has_java_resources': 1,
+ 'R_package': 'dummy.dep',
+ 'R_package_relpath': 'dummy/dep',
+ },
+ 'includes': [ '../../../../build/java.gypi' ],
+ },
+ {
+ 'target_name': 'bad_resources_test_apk',
+ 'type': 'none',
+ 'dependencies': ['bad_resources_dep'],
+ 'variables': {
+ 'app_manifest_version_name%': '<(android_app_version_name)',
+ 'java_in_dir': 'app/java',
+ 'resource_dir': 'app/res',
+ 'R_package': 'dummy',
+ 'R_package_relpath': 'dummy',
+ 'apk_name': 'BadResources',
+ # This is a build-only test. There's nothing to install.
+ 'gyp_managed_install': 0,
+ # Include this APK's resources in the R.java files of it's dependencies
gunsch 2015/05/08 17:48:14 grammar nit: it's --> its
+ 'include_all_resources': 1,
+ },
+ 'includes': [ '../../../../build/java_apk.gypi' ],
+ },
+ ],
+}

Powered by Google App Engine
This is Rietveld 408576698