Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1136643004: Switch remaining functions from SchemeIsSecure() to SchemeIsCryptographic(). (Closed)

Created:
5 years, 7 months ago by lgarron
Modified:
5 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch remaining functions from SchemeIsSecure() to SchemeIsCryptographic(). We recently introduced SchemeIsCryptographic() and IsOriginSecure(), which are meant to replace SchemeIsSecure(). IsOriginSecure() roughly means "do we trust this content not to be tampered with before it reaches the user?" [1] This is a higher-level definition that corresponds to the new "privileged contexts" spec. [2] SchemeIsCryptographic() [3] is close to the old definition of SchemeIsSecure(), and literally just checks if the scheme is a cryptographic scheme (HTTPS or WSS as of right now). The difference is that SchemeIsCryptographic() will not consider filesystem URLs secure. IsOriginSecure() should be correct for most Fizz code. [1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866 [2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/ [3] https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666 BUG=362214 Committed: https://crrev.com/92725553228681b9b7a8fd9a9e9f324d32c12018 Cr-Commit-Position: refs/heads/master@{#329310}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebasing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M content/browser/ssl/ssl_policy.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/request_tracker_impl.mm View 6 chunks +9 lines, -10 lines 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/third_party_auth_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (8 generated)
lgarron
Would you guys mind reviewing lines in the following files? (See the CR description for ...
5 years, 7 months ago (2015-05-08 02:50:16 UTC) #1
lgarron
Would you guys mind reviewing lines in the following files? (See the CR description for ...
5 years, 7 months ago (2015-05-08 02:52:42 UTC) #3
lgarron
https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc File third_party/libaddressinput/chromium/chrome_metadata_source.cc (right): https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc#newcode91 third_party/libaddressinput/chromium/chrome_metadata_source.cc:91: if (!resource.SchemeIsCryptographic()) { rouslan@: The pre-commit hook tells me ...
5 years, 7 months ago (2015-05-08 03:00:58 UTC) #4
please use gerrit instead
third_party/libaddressinput/chromium/chrome_metadata_source.cc lgtm https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc File third_party/libaddressinput/chromium/chrome_metadata_source.cc (right): https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc#newcode91 third_party/libaddressinput/chromium/chrome_metadata_source.cc:91: if (!resource.SchemeIsCryptographic()) { On 2015/05/08 03:00:58, lgarron ...
5 years, 7 months ago (2015-05-08 14:30:46 UTC) #5
stuartmorgan
ios/ LGTM
5 years, 7 months ago (2015-05-08 14:31:51 UTC) #6
please use gerrit instead
On 2015/05/08 03:00:58, lgarron wrote: > I don't see the chromium/ folder "upstream", but that ...
5 years, 7 months ago (2015-05-08 14:34:18 UTC) #7
lgarron
https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc File third_party/libaddressinput/chromium/chrome_metadata_source.cc (right): https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc#newcode91 third_party/libaddressinput/chromium/chrome_metadata_source.cc:91: if (!resource.SchemeIsCryptographic()) { On 2015/05/08 at 14:30:46, Rouslan Solomakhin ...
5 years, 7 months ago (2015-05-08 18:46:52 UTC) #8
lgarron
https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc File third_party/libaddressinput/chromium/chrome_metadata_source.cc (right): https://codereview.chromium.org/1136643004/diff/1/third_party/libaddressinput/chromium/chrome_metadata_source.cc#newcode91 third_party/libaddressinput/chromium/chrome_metadata_source.cc:91: if (!resource.SchemeIsCryptographic()) { On 2015/05/08 at 14:30:46, Rouslan Solomakhin ...
5 years, 7 months ago (2015-05-08 18:46:52 UTC) #9
maniscalco
sync/internal_api/sync_manager_impl.cc LGTM
5 years, 7 months ago (2015-05-08 20:15:15 UTC) #10
asargent_no_longer_on_chrome
extension_downloader.cc lgtm
5 years, 7 months ago (2015-05-08 21:37:35 UTC) #11
nasko
If I were you, I'd split each owner area into a separate CL. That way ...
5 years, 7 months ago (2015-05-08 22:02:27 UTC) #12
Sergey Ulanov
remoting lgtm
5 years, 7 months ago (2015-05-08 23:31:01 UTC) #13
Roger Tawa OOO till Jul 10th
google_apis lgtm
5 years, 7 months ago (2015-05-11 17:44:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136643004/1
5 years, 7 months ago (2015-05-11 19:44:23 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/23646) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-11 19:49:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136643004/20001
5 years, 7 months ago (2015-05-11 22:38:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136643004/20001
5 years, 7 months ago (2015-05-12 01:55:35 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 02:03:25 UTC) #26
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:04:37 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92725553228681b9b7a8fd9a9e9f324d32c12018
Cr-Commit-Position: refs/heads/master@{#329310}

Powered by Google App Engine
This is Rietveld 408576698