Source/core/editing/ReplaceSelectionCommand.cpp - Issue 113663003: Keep br while replacing plain texts with content ending with newline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 113663003: Keep br while replacing plain texts with content ending with newline (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove wrongly name test file Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/pasteboard/paste-newline-in-all-selected-textarea.html ('K') | « LayoutTests/editing/pasteboard/paste-newline-in-all-selected-textarea-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 5b7939ef51b9433aab5a09051892b28cd4dab46e..50f5ae214cca5b966558e58671b1d15663254ae0 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -1125,7 +1125,7 @@ void ReplaceSelectionCommand::doApply()

if (insertionBlock && insertionPos.deprecatedNode() == insertionBlock->parentNode() && (unsigned)insertionPos.deprecatedEditingOffset() < insertionBlock->nodeIndex() && !isStartOfParagraph(startOfInsertedContent))

insertNodeAt(createBreakElement(document()).get(), startOfInsertedContent.deepEquivalent());

- if (endBR && (plainTextFragment || shouldRemoveEndBR(endBR, originalVisPosBeforeEndBR))) {

+ if (endBR && (plainTextFragment || (shouldRemoveEndBR(endBR, originalVisPosBeforeEndBR) && !(fragment.hasInterchangeNewlineAtEnd() && selectionIsPlainText)))) {

RefPtr<Node> parent = endBR->parentNode();

insertedNodes.willRemoveNode(*endBR);

removeNode(endBR);