LayoutTests/editing/pasteboard/paste-newline-in-all-selected-textarea.html - Issue 113663003: Keep br while replacing plain texts with content ending with newline

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/pasteboard/paste-newline-in-all-selected-textarea.html

Issue 113663003: Keep br while replacing plain texts with content ending with newline (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add test case for paste newline in a all selected textarea Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/editing/pasteboard/paste-newline-in-all-selected-textarea-expeted.txt » ('j') | Source/core/editing/ReplaceSelectionCommand.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <textarea id="test" cols=5 rows=4>

	5 test

	6

	7 </textarea>

	8 <script src="../../resources/js-test.js"></script>

	9 <script>

	10
	yosin_UTC9 2013/12/20 01:23:06 nit: Please remove an extra blank line. nit: Please remove an extra blank line. ziran.sun 2014/01/02 16:03:30 Done. Show quoted text On 2013/12/20 01:23:06, Yoshi wrote: > nit: Please remove an extra blank line. Done.
	11 if (window.testRunner)

	12 testRunner.dumpAsText();
	yosin_UTC9 2013/12/20 01:23:06 You don't need to call testRunner.dumpAsText(). js You don't need to call testRunner.dumpAsText(). js-test.js does for you. See http://src.chromium.org/viewvc/blink/trunk/LayoutTests/resources/js-test.js?r... ziran.sun 2014/01/02 16:03:30 Done. Show quoted text On 2013/12/20 01:23:06, Yoshi wrote: > You don't need to call testRunner.dumpAsText(). js-test.js does for you. > See > http://src.chromium.org/viewvc/blink/trunk/LayoutTests/resources/js-test.js?r... Done.
	13

	14 var newlineText = '\n';
	yosin_UTC9 2013/12/20 01:23:06 nit: We don't need to use \|newlineText\|. nit: We don't need to use \|newlineText\|. ziran.sun 2014/01/02 16:03:30 Done. Show quoted text On 2013/12/20 01:23:06, Yoshi wrote: > nit: We don't need to use \|newlineText\|. Done.
	15 var textarea = document.getElementById("test");

	16 textarea.focus();

	17

	18 //copy a new line
	yosin_UTC9 2013/12/20 01:23:06 nit: Please put a space after "//" nit: Please put a space after "//" ziran.sun 2014/01/02 16:03:30 Done. Show quoted text On 2013/12/20 01:23:06, Yoshi wrote: > nit: Please put a space after "//" Done.
	19 textarea.setSelectionRange(4, 5);

	20 document.execCommand("copy");

	21

	22 document.execCommand("SelectAll");

	23 document.execCommand("paste");

	24 shouldBeEqualToString('textarea.value', newlineText);

	25
	yosin_UTC9 2013/12/20 01:23:06 nit: Please remove an extra blank line. nit: Please remove an extra blank line. ziran.sun 2014/01/02 16:03:30 Done. Show quoted text On 2013/12/20 01:23:06, Yoshi wrote: > nit: Please remove an extra blank line. Done.
	26 </script>

	27 </body>

	28 </html>

	29

OLD	NEW