Add logic to block the use of client 3D APIs (WebGL, Pepper 3D) if context lost notifications are r…

content/public/browser/gpu_data_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_GPU_DATA_MANAGER_H_
 #define CONTENT_PUBLIC_BROWSER_GPU_DATA_MANAGER_H_
 
 #include <string>
 
 #include "content/common/content_export.h"
 #include "content/public/common/gpu_feature_type.h"
 #include "content/public/common/gpu_switching_option.h"
 
 class FilePath;
+class GURL;
 
 namespace base {
 class ListValue;
 }
 
 namespace content {
 
 class GpuDataManagerObserver;
 struct GPUInfo;
 
 // This class is fully thread-safe.
 class GpuDataManager {
  public:
+  // Indicates the guilt level of a domain which caused a GPU reset.
+  // If a domain is 100% known to be guilty of resetting the GPU, then
+  // it will generally not cause other domains' use of 3D APIs to be
+  // blocked, unless system stability would be compromised.
+  enum DomainGuilt {
+    kKnownGuilty,

[jam, 2012/11/14 18:21:57]

nit: here and below, please use chrome recommended style for enum values, i.e.
DOMAIN_GUILT_KNOWN, DOMAIN_BLOCK_STATUS_BLOCKED..

also, it's hard for content-api reviewers to review these changes without seeing
the chrome side. why are they not together? i.e. why is the test in chrome, if
it were in content (which it seems that it should, since content code should be
tested in content) then the ForTesting method can be hidden

[Ken Russell (switch to Gerrit), 2012/11/14 19:09:14]

Will change -- sorry, I'd missed this in the Chromium style guide.
I wanted to split off this patch to avoid having one gigantic patch to review.
The chrome side will be large enough as it is. The tests currently must live in
chrome because they cause infobars to be raised. Some other preexisting
chrome-side tests (gpu_crash_browsertest.cc) now need to suppress the raising of
infobars which is why the ForTesting method is needed.

+    kUnknownGuilt
+  };
+
+  // Indicates the reason that access to a given client API (like
+  // WebGL or Pepper 3D) was blocked or not. This state is distinct
+  // from blacklisting of an entire feature.
+  enum DomainBlockStatus {
+    kDomainBlocked,
+    kAllDomainsBlocked,
+    kNotBlocked
+  };
+
   // Getter for the singleton.
   CONTENT_EXPORT static GpuDataManager* GetInstance();
 
   virtual void InitializeForTesting(const std::string& gpu_blacklist_json,
                                     const content::GPUInfo& gpu_info) = 0;
 
   virtual std::string GetBlacklistVersion() const = 0;
 
   virtual GpuFeatureType GetBlacklistedFeatures() const = 0;
 
@@ skipping 39 matching lines @@
 
   // Registers/unregister |observer|.
   virtual void AddObserver(GpuDataManagerObserver* observer) = 0;
   virtual void RemoveObserver(GpuDataManagerObserver* observer) = 0;
 
   // Notifies the gpu process about the number of browser windows, so
   // they can be used to determine managed memory allocation.
   virtual void SetWindowCount(uint32 count) = 0;
   virtual uint32 GetWindowCount() const = 0;
 
+  // Maintenance of domains requiring explicit user permission before
+  // using client-facing 3D APIs (WebGL, Pepper 3D), either because
+  // the domain has caused the GPU to reset, or because too many GPU
+  // resets have been observed globally recently, and system stability
+  // might be compromised.
+  //
+  // The given URL may be a partial URL (including at least the host)
+  // or a full URL to a page.
+  virtual void BlockDomainFrom3DAPIs(const GURL& url, DomainGuilt guilt) = 0;
+  virtual DomainBlockStatus Are3DAPIsBlocked(
+      const GURL& url) const = 0;
+  virtual void UnblockDomainFrom3DAPIs(const GURL& url) = 0;
+  // Disables domain blocking. For use only in tests.
+  virtual void DisableDomainBlockingFor3DAPIsForTesting() = 0;
+
  protected:
   virtual ~GpuDataManager() {}
 };
 
 };  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_GPU_DATA_MANAGER_H_