Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 11366221: Merge 133885 - Web Inspector: Add option to disable rulers (Elements panel) (Closed)

Created:
8 years, 1 month ago by apavlov
Modified:
8 years, 1 month ago
Reviewers:
apavlov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133885 - Web Inspector: Add option to disable rulers (Elements panel) https://bugs.webkit.org/show_bug.cgi?id=101554 Reviewed by Pavel Feldman. A new setting, showMetricsRulers, has been introduced (off by default, so users need to opt in to see the rulers). The setting value is passed into InspectorDOMAgent, down to the InspectorOverlayPage, which affects the drawGrid() and drawRulers() calls. As a side effect, the issue when the rulers were painted for elements having no renderers has been fixed. No new tests, a UI change. * English.lproj/localizedStrings.js: Add "Show rulers" string. * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject): Copy over the showRulers value. * inspector/InspectorOverlay.cpp: (WebCore::buildObjectForHighlight): Copy over the showRulers value. * inspector/InspectorOverlay.h: (HighlightConfig): Add |bool showRulers|. (WebCore::Highlight::Highlight): Initialize fields. (Highlight): Add |bool showRulers|. (WebCore::Highlight::setDataFromConfig): * inspector/InspectorOverlayPage.html: * inspector/front-end/DOMAgent.js: Make use of WebInspector.settings.showMetricsRulers when building the highlight DTO. * inspector/front-end/Settings.js: Add showMetricsRulers. * inspector/front-end/SettingsScreen.js: (WebInspector.GenericSettingsTab): Add "Show rulers" checkbox in the Elements panel section. TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M Source/WebCore/English.lproj/localizedStrings.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMAgent.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorOverlay.h View 3 chunks +10 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorOverlay.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorOverlayPage.html View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/DOMAgent.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/Settings.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/SettingsScreen.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
apavlov
8 years, 1 month ago (2012-11-13 15:15:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698