ash/wm/workspace/workspace_window_resizer.cc - Issue 11366215: Prevents windows in chromeos from resizing bigger than their maximum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_window_resizer.cc

Issue 11366215: Prevents windows in chromeos from resizing bigger than their maximum size. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/workspace/workspace_window_resizer.cc

diff --git a/ash/wm/workspace/workspace_window_resizer.cc b/ash/wm/workspace/workspace_window_resizer.cc

index eda27a49ffe996678e1bd012d82c7d571eef7948..54bc6ca7169636e2bb85185558f947c750311735 100644

--- a/ash/wm/workspace/workspace_window_resizer.cc

+++ b/ash/wm/workspace/workspace_window_resizer.cc

@@ -754,6 +754,10 @@ void WorkspaceWindowResizer::UpdateSnapPhantomWindow(const gfx::Point& location,

if (!did_move_or_resize_ || details_.window_component != HTCAPTION)

return;

+ // If a window has a maximum size defined, snapping may make it too big.

+ if (!window()->delegate()->GetMaximumSize().IsEmpty())

jeremya 2012/11/15 01:12:43 Maybe abstract this into ash::wm::CanSnapWindow()

koz (OOO until 15th September) 2012/11/15 02:46:13 Done.

+ return;

SnapType last_type = snap_type_;

snap_type_ = GetSnapType(location);

if (snap_type_ == SNAP_NONE || snap_type_ != last_type) {

« ash/wm/window_resizer.cc ('K') | « ash/wm/workspace/workspace_window_resizer.h ('k') | ash/wm/workspace/workspace_window_resizer_unittest.cc » ('j') | no next file with comments »