Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 11366212: cc: Add command line flags for the various show rect debugging features. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
jamesr, jam, enne (OOO)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, shawnsingh, piman, backer
Visibility:
Public.

Description

cc: Add command line flags for the various show rect debugging features. Add command line flags for everything except showPaintRects, as this is already a part of WebSettings and passed in via WebKit. This needs to be resolved with the others once we sort out the future method of passing in settings to the compositor. The new flags are: --show-property-changed-rects --show-surface-damage-rects --show-screenspace-rects --show-replica-screenspace-rects --show-occluding-rects BUG=160643 R=enne,jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167484

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M cc/layer_tree_host.cc View 3 chunks +8 lines, -0 lines 1 comment Download
M cc/switches.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/switches.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
8 years, 1 month ago (2012-11-13 03:04:58 UTC) #1
danakj
+jam for content/
8 years, 1 month ago (2012-11-13 03:05:33 UTC) #2
tfarina
https://codereview.chromium.org/11366212/diff/1/cc/layer_tree_host.cc File cc/layer_tree_host.cc (right): https://codereview.chromium.org/11366212/diff/1/cc/layer_tree_host.cc#newcode57 cc/layer_tree_host.cc:57: showPropertyChangedRects = CommandLine::ForCurrentProcess()->HasSwitch(cc::switches::kShowPropertyChangedRects); do we need cc:: here? We ...
8 years, 1 month ago (2012-11-13 15:00:19 UTC) #3
jam
lgtm
8 years, 1 month ago (2012-11-13 20:41:07 UTC) #4
enne (OOO)
8 years, 1 month ago (2012-11-13 21:42:14 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698