Issue 11366204: Rename SafeBrowsingServiceTest in safe_browsing_test.cc to SafeBrowsingServerTest to avoid collisio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366204: Rename SafeBrowsingServiceTest in safe_browsing_test.cc to SafeBrowsingServerTest to avoid collisio… (Closed)

Created:
8 years, 1 month ago by jam

Modified:
8 years, 1 month ago

Reviewers:
mattm

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Rename SafeBrowsingServiceTest in safe_browsing_test.cc to SafeBrowsingServerTest to avoid collision with SafeBrowsingServiceTest in safe_browsing_service_browsertest.cc. This is in prepartion to https://codereview.chromium.org/11366196/ landing (after master restarts) which moves safe_browsing_test.cc to browser_tests to avoid building another target just for this one test. BUG=148792 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167257

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -28 lines)			Patch
M	chrome/browser/safe_browsing/protocol_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_test.cc	View	12 chunks	+24 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattm

lgtm, thanks! You could tag these with BUG=148792 if you want.

8 years, 1 month ago (2012-11-12 23:06:43 UTC) #2

jam

8 years, 1 month ago (2012-11-12 23:13:51 UTC) #3

On 2012/11/12 23:06:43, mattm wrote:
> lgtm, thanks!
> 
> You could tag these with BUG=148792 if you want.

done (didn't know about it). btw i've verified that the test does succeed in
browser_tests. I have left it in the current disabled state though.

Expand Messages | Collapse Messages