Move the safe browsing test into browser_tests instead of having a separate browser test binary. Th…

Move the safe browsing test into browser_tests instead of having a separate browser test binary. This saves us from having to link all of chrome for this one binary.

This depends on r167206 and r167207 landing and all the relevant masters restart.

BUG=148792
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168483

[nsylvain, 2012-11-12 17:53:31]

lgtm

[jam, 2012-11-12 18:06:44]

question: is there a way I can check when all the masters from the other two
changes have restarted? i.e. instead of asking infrastructure team?

[nsylvain, 2012-11-12 18:49:14]

On Mon, Nov 12, 2012 at 10:06 AM, <jam@chromium.org> wrote:

> question: is there a way I can check when all the masters from the other
> two
> changes have restarted? i.e. instead of asking infrastructure team?
>
You'll notice that the steps are not running anymore. There is no easy way
to know which SVN rev a master is running.  (although this would be a
really nice feature to add)

>
>
https://codereview.chromium.**org/11366196/<https://codereview.chromium.org/1...
>

[jam, 2012-11-12 19:31:04]

On 2012/11/12 18:49:14, nsylvain wrote:
> On Mon, Nov 12, 2012 at 10:06 AM, <mailto:jam@chromium.org> wrote:
> 
> > question: is there a way I can check when all the masters from the other
> > two
> > changes have restarted? i.e. instead of asking infrastructure team?
> >
> You'll notice that the steps are not running anymore. There is no easy way
> to know which SVN rev a master is running.  (although this would be a
> really nice feature to add)

ah ok, cool I will just watch for that.

Is there a regular master restart schedule, i.e. once a week?

[nsylvain, 2012-11-12 19:32:22]

On Mon, Nov 12, 2012 at 11:31 AM, <jam@chromium.org> wrote:

> On 2012/11/12 18:49:14, nsylvain wrote:
>
>  On Mon, Nov 12, 2012 at 10:06 AM, <mailto:jam@chromium.org> wrote:
>>
>
>  > question: is there a way I can check when all the masters from the other
>> > two
>> > changes have restarted? i.e. instead of asking infrastructure team?
>> >
>> You'll notice that the steps are not running anymore. There is no easy way
>> to know which SVN rev a master is running.  (although this would be a
>> really nice feature to add)
>>
>
> ah ok, cool I will just watch for that.
>
> Is there a regular master restart schedule, i.e. once a week?
>
No.  We have too many masters to do this these days.  We only need what has
to be restarted.

Nicolas


>
>
https://codereview.chromium.**org/11366196/<https://codereview.chromium.org/1...
>

[jam, 2012-11-12 19:35:37]

On 2012/11/12 19:32:22, nsylvain wrote:
> On Mon, Nov 12, 2012 at 11:31 AM, <mailto:jam@chromium.org> wrote:
> 
> > On 2012/11/12 18:49:14, nsylvain wrote:
> >
> >  On Mon, Nov 12, 2012 at 10:06 AM, <mailto:jam@chromium.org> wrote:
> >>
> >
> >  > question: is there a way I can check when all the masters from the other
> >> > two
> >> > changes have restarted? i.e. instead of asking infrastructure team?
> >> >
> >> You'll notice that the steps are not running anymore. There is no easy way
> >> to know which SVN rev a master is running.  (although this would be a
> >> really nice feature to add)
> >>
> >
> > ah ok, cool I will just watch for that.
> >
> > Is there a regular master restart schedule, i.e. once a week?
> >
> No.  We have too many masters to do this these days.  We only need what has
> to be restarted.
> 
> Nicolas

I see. So is there a recommended way to request this? i.e. should I email
chrome-infrastructure to request master restart for all these?

[nsylvain, 2012-11-12 19:40:40]

On Mon, Nov 12, 2012 at 11:35 AM, <jam@chromium.org> wrote:

> On 2012/11/12 19:32:22, nsylvain wrote:
>
>  On Mon, Nov 12, 2012 at 11:31 AM, <mailto:jam@chromium.org> wrote:
>>
>
>  > On 2012/11/12 18:49:14, nsylvain wrote:
>> >
>> >  On Mon, Nov 12, 2012 at 10:06 AM, <mailto:jam@chromium.org> wrote:
>> >>
>> >
>> >  > question: is there a way I can check when all the masters from the
>> other
>> >> > two
>> >> > changes have restarted? i.e. instead of asking infrastructure team?
>> >> >
>> >> You'll notice that the steps are not running anymore. There is no easy
>> way
>> >> to know which SVN rev a master is running.  (although this would be a
>> >> really nice feature to add)
>> >>
>> >
>> > ah ok, cool I will just watch for that.
>> >
>> > Is there a regular master restart schedule, i.e. once a week?
>> >
>> No.  We have too many masters to do this these days.  We only need what
>> has
>> to be restarted.
>>
>
>  Nicolas
>>
>
> I see. So is there a recommended way to request this? i.e. should I email
> chrome-infrastructure to request master restart for all these?
>
chrome-troopers@google.com is probably best. Or file a bug at
go/chromeinfraticket


Nicolas


>
>
https://codereview.chromium.**org/11366196/<https://codereview.chromium.org/1...
>