Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: net/socket_stream/socket_stream.cc

Issue 11366155: SSLClientSocket::IsConnected should care for internal buffers (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: add unit test Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/ssl_client_socket_nss.cc ('K') | « net/socket/ssl_client_socket_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream.cc
diff --git a/net/socket_stream/socket_stream.cc b/net/socket_stream/socket_stream.cc
index 73d5a2b9cdc6d70ab60a17b9ddacc5b2065adbd2..478d102b7c2e6e505fe837ed3f837067b5d711f8 100644
--- a/net/socket_stream/socket_stream.cc
+++ b/net/socket_stream/socket_stream.cc
@@ -1067,7 +1067,8 @@ int SocketStream::DoReadWrite(int result) {
next_state_ = STATE_CLOSE;
return result;
}
- if (!socket_.get() || !socket_->IsConnected()) {
Ryan Sleevi 2012/12/15 01:03:04 I have to agree with Wan-Teh: I think this functio
Takashi Toyoshima 2012/12/21 07:43:03 Yes. Removing IsConnected() check is easy and righ
+ //if (!socket_.get() || !socket_->IsConnected()) {
tyoshino (SeeGerritForStatus) 2012/12/14 15:13:54 To be removed before submission?
Takashi Toyoshima 2012/12/21 06:39:03 Oops, this change is not expected, but just for te
+ if (!socket_.get()) {
next_state_ = STATE_CLOSE;
return ERR_CONNECTION_CLOSED;
}
« net/socket/ssl_client_socket_nss.cc ('K') | « net/socket/ssl_client_socket_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698