SSLClientSocket::IsConnected should care for internal buffers

net/socket/ssl_client_socket_nss.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_
 
 #include <certt.h>
 #include <keyt.h>
 #include <nspr.h>
@@ skipping 153 matching lines @@
   ServerBoundCertService* server_bound_cert_service_;
 
   // ssl_session_cache_shard_ is an opaque string that partitions the SSL
   // session cache. i.e. sessions created with one value will not attempt to
   // resume on the socket with a different value.
   const std::string ssl_session_cache_shard_;
 
   // True if the SSL handshake has been completed.
   bool completed_handshake_;
 
+  // True if |core_| detects EOF.

[tyoshino (SeeGerritForStatus), 2012/12/14 15:13:54]

has detected

[Takashi Toyoshima, 2012/12/21 06:39:03]

Done.

+  bool core_recv_eof_;

[wtc, 2012/12/14 22:55:14]

I suggest we name this member ssl_recv_eof_, to contrast with
the transport_recv_eof_ member.

This member means the SSL read (PR_Read on the NSS SSL socket)
returns 0. In contrast, transport_recv_eof_ means
transport_socket_->Read() returns 0 (maybe asynchronously).

+
   State next_handshake_state_;
 
   // The NSS SSL state machine. This is owned by |core_|.
   // TODO(rsleevi): http://crbug.com/130616 - Remove this member once
   // ExportKeyingMaterial is updated to be asynchronous.
   PRFileDesc* nss_fd_;
 
   BoundNetLog net_log_;
 
   base::TimeTicks start_cert_verification_time_;
 
   TransportSecurityState* transport_security_state_;
 
   // The following two variables are added for debugging bug 65948. Will
   // remove this code after fixing bug 65948.
   // Added the following code Debugging in release mode.
   mutable base::Lock lock_;
   // This is mutable so that CalledOnValidThread can set it.
   // It's guarded by |lock_|.
   mutable base::PlatformThreadId valid_thread_id_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_