[Media Gallery][ChromeOS] Improve device media gallery names.

chrome/browser/system_monitor/removable_device_notifications_chromeos.h

Index: chrome/browser/system_monitor/removable_device_notifications_chromeos.h
diff --git a/chrome/browser/system_monitor/removable_device_notifications_chromeos.h b/chrome/browser/system_monitor/removable_device_notifications_chromeos.h
index a767e8557441c152b02f05c7e4570256a34c4570..3d8542f12254c8bb4bd2003a0c6413e5992ba212 100644
--- a/chrome/browser/system_monitor/removable_device_notifications_chromeos.h
+++ b/chrome/browser/system_monitor/removable_device_notifications_chromeos.h
@@ -60,12 +60,23 @@ class RemovableDeviceNotificationsCros
       const FilePath& path,
       base::SystemMonitor::RemovableStorageInfo* device_info) const;
 
+  // Returns the storage size information of the device present at |location|.
+  // If the requested information is unavailable, returns an empty string.
+  string16 GetStorageSizeInfo(const std::string& location);
+
  private:
+  struct StorageObjectInfo {
+    // Basic details {storage device name, location and identifier}.
+    base::SystemMonitor::RemovableStorageInfo storage_info;
+
+    // Device storage size, e.g "4 GB", "15.9 MB".
+    string16 storage_size_info;

[Lei Zhang, 2012/11/09 01:12:18]

How about storage_size_str ?

[Lei Zhang, 2012/11/09 04:47:05]

BTW, have you considered just storing this as a uint64, instead of a string?
That way, only the common places that need to format it for human readability
can call FormatBytes(), rather than every GetStorageInfo() function.

[kmadhusu, 2012/11/09 21:59:40]

storage_size_info -> storage_size.

[kmadhusu, 2012/11/09 21:59:40]

I don't see any reason to store this as uint64. Every caller who access this
function will eventually call FormatBytes.

[Lei Zhang, 2012/11/12 07:46:56]

So with this CL and the Linux equivalent, both
removable_device_notifications_chromeos.cc and
removable_device_notifications_linux.cc have to call FormatBytes() in their
respective GetDeviceInfo functions.

Alternatively, you can keep it as a uint64, then the function that calls
FormatBytes() will be GetDisplayNameForDevice(). Wouldn't calling FormatBytes()
in the function that format the names for display make more sense?

[kmadhusu, 2012/11/12 19:56:56]

Done.

+  };
+
   friend class base::RefCountedThreadSafe<RemovableDeviceNotificationsCros>;
 
   // Mapping of mount path to removable mass storage info.
-  typedef std::map<std::string, base::SystemMonitor::RemovableStorageInfo>
-      MountMap;
+  typedef std::map<std::string, StorageObjectInfo> MountMap;
 
   // Private to avoid code deleting the object.
   virtual ~RemovableDeviceNotificationsCros();