Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4995)

Unified Diff: chrome/browser/system_monitor/media_device_notifications_utils.h

Issue 11366144: [Media Gallery][ChromeOS] Improve device media gallery names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments + Added util functions Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/system_monitor/media_device_notifications_utils.h
diff --git a/chrome/browser/system_monitor/media_device_notifications_utils.h b/chrome/browser/system_monitor/media_device_notifications_utils.h
index 46980b185b9e1d0a32d3f37133a3060f3dacaff0..12c35a7e5d8412126f94c343574e1ddc6956862e 100644
--- a/chrome/browser/system_monitor/media_device_notifications_utils.h
+++ b/chrome/browser/system_monitor/media_device_notifications_utils.h
@@ -18,6 +18,16 @@ namespace chrome {
// TODO(vandebo) Try to figure out how Mac OS X decides this.
bool IsMediaDevice(const FilePath::StringType& mount_point);
+// Constructs and returns a device manufacturer name from |vendor_name|
+// and |model_name|.
+std::string GetDeviceManufacturerName(const std::string& vendor_name,
Lei Zhang 2012/11/12 07:46:56 This name is confusing. For computer products, "ma
kmadhusu 2012/11/12 19:56:56 Done.
+ const std::string& model_name);
+
+// Constructs and returns a display name for device from |device_partition_size|
+// and |name|.
+string16 GetDisplayNameForDevice(const string16& device_partition_size,
Lei Zhang 2012/11/12 07:46:56 You need to #include string16.h in the header.
kmadhusu 2012/11/12 19:56:56 Done.
+ const string16& name);
+
} // namespace chrome
#endif // CHROME_BROWSER_SYSTEM_MONITOR_MEDIA_DEVICE_NOTIFICATIONS_UTILS_H_

Powered by Google App Engine
This is Rietveld 408576698