Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/system_monitor/media_device_notifications_utils.h

Issue 11366144: [Media Gallery][ChromeOS] Improve device media gallery names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/system_monitor/media_device_notifications_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/system_monitor/media_device_notifications_utils.h
diff --git a/chrome/browser/system_monitor/media_device_notifications_utils.h b/chrome/browser/system_monitor/media_device_notifications_utils.h
index 46980b185b9e1d0a32d3f37133a3060f3dacaff0..fad77e3bcd8f66dc0fdbef5ac61e264476170bff 100644
--- a/chrome/browser/system_monitor/media_device_notifications_utils.h
+++ b/chrome/browser/system_monitor/media_device_notifications_utils.h
@@ -8,6 +8,7 @@
#define CHROME_BROWSER_SYSTEM_MONITOR_MEDIA_DEVICE_NOTIFICATIONS_UTILS_H_
#include "base/file_path.h"
+#include "base/string16.h"
namespace chrome {
@@ -18,6 +19,15 @@ namespace chrome {
// TODO(vandebo) Try to figure out how Mac OS X decides this.
bool IsMediaDevice(const FilePath::StringType& mount_point);
+// Constructs the device product name from |vendor_name| and |model_name|.
+std::string GetFullProductName(const std::string& vendor_name,
Lei Zhang 2012/11/13 01:13:07 Also, have you considered moving the IsStringUTF8(
kmadhusu 2012/11/13 01:37:32 As we discussed, all the callers of this function
+ const std::string& model_name);
+
+// Constructs the display name for device from |storage_size_in_bytes| and
+// |name|.
+string16 GetDisplayNameForDevice(uint64 storage_size_in_bytes,
+ const string16& name);
+
} // namespace chrome
#endif // CHROME_BROWSER_SYSTEM_MONITOR_MEDIA_DEVICE_NOTIFICATIONS_UTILS_H_
« no previous file with comments | « no previous file | chrome/browser/system_monitor/media_device_notifications_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698