[Media Gallery][ChromeOS] Improve device media gallery names.

chrome/browser/system_monitor/media_storage_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // chrome::MediaStorageUtil implementation.
 
 #include "chrome/browser/system_monitor/media_storage_util.h"
 
 #include <vector>
 
@@ skipping 236 matching lines @@
 
 #if defined(OS_LINUX)
   if (!found_device) {
     MediaTransferProtocolDeviceObserverLinux* mtp_manager =
         MediaTransferProtocolDeviceObserverLinux::GetInstance();
     found_device = mtp_manager->GetStorageInfoForPath(path, &device_info);
   }
 #endif
 
   if (found_device && IsRemovableDevice(device_info.device_id)) {
+    FilePath sub_folder_path;
+    if (device_name || relative_path) {
+      bool success = FilePath(device_info.location)
+          .AppendRelativePath(path, &sub_folder_path);
+      DCHECK(success);
+    }
+
+#if defined(OS_CHROMEOS)
+    if (device_name) {
+      *device_name = notifier->GetStorageSizeInfo(device_info.location) +

[Lei Zhang, 2012/11/08 07:42:44]

Consider localizing this as well?

Is this going to stay CrOS only?

[kmadhusu, 2012/11/08 18:50:35]

Modified code to use FormatBytes() and it localizes the byte block units.
No. I will update windows, linux and mac code in a separate CL.

+          ASCIIToUTF16(" ");
+      if (!sub_folder_path.value().empty()) {
+        *device_name += ASCIIToUTF16(" (") +
+            sub_folder_path.BaseName().LossyDisplayName() + ASCIIToUTF16(") ");
+      }
+    }
+#endif
+
     if (device_id)
       *device_id = device_info.device_id;
     if (device_name)
-      *device_name = device_info.name;
-    if (relative_path) {
-      *relative_path = FilePath();
-      FilePath mount_point(device_info.location);
-      bool success = mount_point.AppendRelativePath(path, relative_path);
-#if defined(OS_POSIX)
-      if (!relative_path->value().empty() && device_name) {
-        *device_name += ASCIIToUTF16(" (") +
-            relative_path->BaseName().LossyDisplayName() + ASCIIToUTF16(")");
-      }
-#endif
-      DCHECK(success);
-    }
+      *device_name += device_info.name;
+    if (relative_path)
+      *relative_path = sub_folder_path;
     return true;
   }
 
   // On Posix systems, there's one root so any absolute path could be valid.
 #if !defined(OS_POSIX)
   if (!found_device)
     return false;
 #endif
 
   if (device_id)
@@ skipping 48 matching lines @@
 
 // static
 void MediaStorageUtil::SetGetDeviceInfoFromPathFunctionForTesting(
     GetDeviceInfoFromPathFunction function) {
   g_test_get_device_info_from_path_function = function;
 }
 
 MediaStorageUtil::MediaStorageUtil() {}
 
 }  // namespace chrome