Issue 11366141: Revert 166547 - Use tcmalloc's debugallocation for Debug builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366141: Revert 166547 - Use tcmalloc's debugallocation for Debug builds (Closed)

Created:
8 years, 1 month ago by scottmg

Modified:
8 years, 1 month ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 166547 - Use tcmalloc's debugallocation for Debug builds to catch memory problems early, easily, and cleanly. Because of gyp limitations, this can't be now controlled by a flag. BUG=30715 TEST=none Review URL: https://codereview.chromium.org/11266019 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166566

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -31 lines)			Patch
M	base/allocator/allocator.gyp	View	6 chunks	+18 lines, -21 lines	0 comments	Download
M	base/allocator/allocator_shim.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	base/allocator/debugallocation_shim.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

some failures for reference: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmedia%2Fremove-while-loading.html%2Chttp%2Ftests%2Fmedia%2Fvideo-throttled-load-metadata.html%2Chttp%2Ftests%2Fmedia%2Fvideo-referer.html%2Chttp%2Ftests%2Fmedia%2Fvideo-query-url.html%2Chttp%2Ftests%2Fmedia%2Fvideo-useragent.html%2Chttp%2F http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29&number=5568 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%281%29&number=22083

8 years, 1 month ago (2012-11-08 01:05:36 UTC) #2

Paweł Hajdan Jr.

8 years, 1 month ago (2012-11-08 17:40:28 UTC) #3

LGTM. Thank you for doing the right thing.

I still think debugallocation is just a messenger/trigger here, but I got the
same failures on the try run, so I shouldn't have landed this. I've reproduced
the failures locally, and will see what can be done about that.

Thank you for including the reference logs too.

Expand Messages | Collapse Messages