Extra logging for NinePatch layers in layerTreeAsText()

Extra logging for NinePatch layers in layerTreeAsText()

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166974

[danakj, 2012-11-07 19:00:01]

yay lgtm

https://codereview.chromium.org/11366135/diff/1/cc/nine_patch_layer_impl.cc
File cc/nine_patch_layer_impl.cc (right):

https://codereview.chromium.org/11366135/diff/1/cc/nine_patch_layer_impl.cc#n...
cc/nine_patch_layer_impl.cc:119: }
}  // namespace cc

[danakj, 2012-11-07 21:31:34]

https://codereview.chromium.org/11366135/diff/1/cc/nine_patch_layer_impl.cc
File cc/nine_patch_layer_impl.cc (right):

https://codereview.chromium.org/11366135/diff/1/cc/nine_patch_layer_impl.cc#n...
cc/nine_patch_layer_impl.cc:115: base::StringAppendF(str, "m_imageAperture:
%s\n", m_imageAperture.ToString().c_str());
nit: drop the m_ it's cleaner.

maybe consider putting the call to the parent first, so the layerId stays at the
top.

[jamesr, 2012-11-07 23:33:22]

PTAL - dropped the m_, but I looked and all the other dumpLayer..() calls call
the base class last.  I could change them all to dump the base properties first
if you'd prefer but want to keep them internally consistent.

[danakj, 2012-11-08 01:22:01]

sure, i don't feel strongly about the ordering, this is fine. thanks :)

http://codereview.chromium.org/11366135/diff/5001/cc/nine_patch_layer_impl.cc
File cc/nine_patch_layer_impl.cc (right):

http://codereview.chromium.org/11366135/diff/5001/cc/nine_patch_layer_impl.cc...
cc/nine_patch_layer_impl.cc:119: }
nit: }  // namespace cc

while you're here

[danakj, 2012-11-08 01:22:05]

lgtm

[commit-bot: I haz the power, 2012-11-09 18:57:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11366135/5001

[commit-bot: I haz the power, 2012-11-09 20:52:36]

Change committed as 166974