Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: content/browser/web_contents/interstitial_page_impl.h

Issue 11366118: Add support for interstitial pages on android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/interstitial_page_impl.h
diff --git a/content/browser/web_contents/interstitial_page_impl.h b/content/browser/web_contents/interstitial_page_impl.h
index dba542760076eac97128369fc656c3817bbfe7ce..15916768cfa654d2e2cc5843a60767cf745ba787 100644
--- a/content/browser/web_contents/interstitial_page_impl.h
+++ b/content/browser/web_contents/interstitial_page_impl.h
@@ -59,6 +59,12 @@ class CONTENT_EXPORT InterstitialPageImpl
virtual void SetSize(const gfx::Size& size) OVERRIDE;
virtual void Focus() OVERRIDE;
+#if defined(OS_ANDROID)
+ // Android shares a single view for all tabs, so we need to expose the
no sievers 2012/11/07 02:46:57 maybe say 'platform window' instead of 'view' here
jam 2012/11/07 17:15:42 +1, that confused me :) nit: can you move this to
Ted C 2012/11/07 18:55:21 Done.
+ // RenderViewHost to properly route gestures to the interstitial.
+ RenderViewHost* GetRenderViewHost() const;
+#endif
+
// Allows the user to navigate away by disabling the interstitial, canceling
// the pending request, and unblocking the hidden renderer. The interstitial
// will stay visible until the navigation completes.
@@ -115,6 +121,11 @@ class CONTENT_EXPORT InterstitialPageImpl
const ContextMenuParams& params,
ContextMenuSourceType type) OVERRIDE;
+#if defined(OS_ANDROID)
+ virtual void AttachLayer(WebKit::WebLayer* layer) OVERRIDE;
+ virtual void RemoveLayer(WebKit::WebLayer* layer) OVERRIDE;
+#endif
+
// RenderWidgetHostDelegate implementation:
virtual void RenderWidgetDeleted(
RenderWidgetHostImpl* render_widget_host) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698