Make Iterable more powerful (and lazy).

sdk/lib/core/collection.dart

Index: sdk/lib/core/collection.dart
diff --git a/sdk/lib/core/collection.dart b/sdk/lib/core/collection.dart
index 51ffc39761c0ec4c42702eb6f6c8db62ef0abe26..a0eaea62054017934ec17a5adcd6e021bff9543a 100644
--- a/sdk/lib/core/collection.dart
+++ b/sdk/lib/core/collection.dart
@@ -4,96 +4,17 @@
 
 /**
  * The common interface of all collections.
- *
- * The [Collection] class contains a skeleton implementation of
- * an iterator based collection.
  */
 abstract class Collection<E> extends Iterable<E> {
   /**
-   * Returns a new collection with the elements [: f(e) :]
-   * for each element [:e:] of this collection.
+   * Adds an element to [this].
    *
-   * Subclasses of [Collection] should implement the [map] method
-   * to return a collection of the same general type as themselves.
-   * E.g., [List.map] should return a [List].
+   * Might throw an [UnsupportedError] if [this] is not extendable.

[Lasse Reichstein Nielsen, 2012/11/14 14:09:12]

"extendable"? I think "extensible" is more common.

[floitsch, 2012/11/16 22:31:07]

Done.

    */
-  Collection map(f(E element));
-
-  /**
-   * Returns a collection with the elements of this collection
-   * that satisfy the predicate [f].
-   *
-   * The returned collection should be of the same type as the collection
-   * creating it.
-   *
-   * An element satisfies the predicate [f] if [:f(element):]
-   * returns true.
-   */
-  Collection<E> filter(bool f(E element));
+  void add(E element);
 
   /**
    * Returns the number of elements in this collection.
    */
   int get length;
-
-  /**
-   * Check whether the collection contains an element equal to [element].
-   */
-  bool contains(E element) {
-    for (E e in this) {
-      if (e == element) return true;
-    }
-    return false;
-  }
-
-  /**
-   * Applies the function [f] to each element of this collection.
-   */
-  void forEach(void f(E element)) {
-    for (E element in this) f(element);
-  }
-
-  /**
-   * Reduce a collection to a single value by iteratively combining each element
-   * of the collection with an existing value using the provided function.
-   * Use [initialValue] as the initial value, and the function [combine] to
-   * create a new value from the previous one and an element.
-   *
-   * Example of calculating the sum of a collection:
-   *
-   *   collection.reduce(0, (prev, element) => prev + element);
-   */
-  Dynamic reduce(var initialValue,
-                 Dynamic combine(var previousValue, E element)) {
-    var value = initialValue;
-    for (E element in this) value = combine(value, element);
-    return value;
-  }
-
-  /**
-   * Returns true if every elements of this collection satisify the
-   * predicate [f]. Returns false otherwise.
-   */
-  bool every(bool f(E element)) {
-    for (E element in this) {
-      if (!f(element)) return false;
-    }
-    return true;
-  }
-
-  /**
-   * Returns true if one element of this collection satisfies the
-   * predicate [f]. Returns false otherwise.
-   */
-  bool some(bool f(E element)) {
-    for (E element in this) {
-      if (f(element)) return true;
-    }
-    return false;
-  }
-
-  /**
-   * Returns true if there is no element in this collection.
-   */
-  bool get isEmpty => !iterator().hasNext;
 }