Chromium Code Reviews| Index: base/debug/trace_event_unittest.cc |
| diff --git a/base/debug/trace_event_unittest.cc b/base/debug/trace_event_unittest.cc |
| index c42cc5dccf80ebf6ba2d0712a7ac85bae183a863..de69557d7e2ab285284061c7af3bd57b0635608b 100644 |
| --- a/base/debug/trace_event_unittest.cc |
| +++ b/base/debug/trace_event_unittest.cc |
| @@ -371,6 +371,21 @@ void TraceWithAllMacroVariants(WaitableEvent* task_complete_event) { |
| TRACE_COUNTER_ID1("all", "TRACE_COUNTER_ID1 call", 0x319009, 31415); |
| TRACE_COUNTER_ID2("all", "TRACE_COUNTER_ID2 call", 0x319009, |
| "a", 30000, "b", 1415); |
| + |
| + TRACE_EVENT_COPY_BEGIN_WITH_ID_TID_AND_TIMESTAMP0("all", |
| + "TRACE_EVENT_COPY_BEGIN_WITH_ID_TID_AND_TIMESTAMP0 call", |
| + 1, 42, 12345); |
|
jar (doing other things)
2013/02/14 02:17:54
nit: please use named (constants?) rather than emb
dsinclair
2013/02/14 15:38:47
Done.
|
| + TRACE_EVENT_COPY_END_WITH_ID_TID_AND_TIMESTAMP0("all", |
| + "TRACE_EVENT_COPY_END_WITH_ID_TID_AND_TIMESTAMP0 call", |
| + 1, 42, 23456); |
| + |
| + TRACE_EVENT_BEGIN_WITH_ID_TID_AND_TIMESTAMP0("all", |
| + "TRACE_EVENT_BEGIN_WITH_ID_TID_AND_TIMESTAMP0 call", |
| + 2, 42, 34567); |
| + TRACE_EVENT_END_WITH_ID_TID_AND_TIMESTAMP0("all", |
| + "TRACE_EVENT_END_WITH_ID_TID_AND_TIMESTAMP0 call", |
| + 2, 42, 45678); |
| + |
| } // Scope close causes TRACE_EVENT0 etc to send their END events. |
| if (task_complete_event) |
| @@ -580,6 +595,54 @@ void ValidateAllTraceMacrosCreatedData(const ListValue& trace_parsed) { |
| EXPECT_TRUE((item && item->GetInteger("args.b", &value))); |
| EXPECT_EQ(1415, value); |
| } |
| + |
| + EXPECT_FIND_("TRACE_EVENT_COPY_BEGIN_WITH_ID_TID_AND_TIMESTAMP0 call"); |
| + { |
| + int val; |
| + EXPECT_TRUE((item && item->GetInteger("ts", &val))); |
| + EXPECT_EQ(12345, val); |
| + EXPECT_TRUE((item && item->GetInteger("tid", &val))); |
| + EXPECT_EQ(42, val); |
| + std::string id; |
| + EXPECT_TRUE((item && item->GetString("id", &id))); |
| + EXPECT_EQ("1", id); |
| + } |
| + |
| + EXPECT_FIND_("TRACE_EVENT_COPY_END_WITH_ID_TID_AND_TIMESTAMP0 call"); |
| + { |
| + int val; |
| + EXPECT_TRUE((item && item->GetInteger("ts", &val))); |
| + EXPECT_EQ(23456, val); |
| + EXPECT_TRUE((item && item->GetInteger("tid", &val))); |
| + EXPECT_EQ(42, val); |
| + std::string id; |
| + EXPECT_TRUE((item && item->GetString("id", &id))); |
| + EXPECT_EQ("1", id); |
| + } |
| + |
| + EXPECT_FIND_("TRACE_EVENT_BEGIN_WITH_ID_TID_AND_TIMESTAMP0 call"); |
| + { |
| + int val; |
| + EXPECT_TRUE((item && item->GetInteger("ts", &val))); |
| + EXPECT_EQ(34567, val); |
| + EXPECT_TRUE((item && item->GetInteger("tid", &val))); |
| + EXPECT_EQ(42, val); |
| + std::string id; |
| + EXPECT_TRUE((item && item->GetString("id", &id))); |
| + EXPECT_EQ("2", id); |
| + } |
| + |
| + EXPECT_FIND_("TRACE_EVENT_END_WITH_ID_TID_AND_TIMESTAMP0 call"); |
| + { |
| + int val; |
| + EXPECT_TRUE((item && item->GetInteger("ts", &val))); |
| + EXPECT_EQ(45678, val); |
| + EXPECT_TRUE((item && item->GetInteger("tid", &val))); |
| + EXPECT_EQ(42, val); |
| + std::string id; |
| + EXPECT_TRUE((item && item->GetString("id", &id))); |
| + EXPECT_EQ("2", id); |
| + } |
| } |
| void TraceManyInstantEvents(int thread_id, int num_events, |