Adding raw tracing to trace framework.

base/debug/trace_event_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 #ifndef BASE_DEBUG_TRACE_EVENT_IMPL_H_
 #define BASE_DEBUG_TRACE_EVENT_IMPL_H_
 
 #include "build/build_config.h"
 
@@ skipping 262 matching lines @@
                     long long threshold,
                     unsigned char flags);
   static void AddTraceEventEtw(char phase,
                                const char* name,
                                const void* id,
                                const char* extra);
   static void AddTraceEventEtw(char phase,
                                const char* name,
                                const void* id,
                                const std::string& extra);
+  int AddTraceEventExplicit(char phase,
+                            const unsigned char* category_enabled,
+                            const char* name,
+                            int thread_id,
+                            int64 timestamp,
+                            unsigned long long id,

[jar (doing other things), 2012/12/06 17:28:59]

nit: Why do we use long long rather than int64 (or in this case, uint64)?

[dsinclair, 2012/12/06 17:38:52]

I used it here to keep consistent with the existing AddTraceEvent method. I
don't know why it was originally chosen, nduca@ maybe able to fill that in.

+                            int num_args,
+                            const char** arg_names,
+                            const unsigned char* arg_types,
+                            const unsigned long long* arg_values,
+                            int threshold_begin_id,
+                            long long threshold,
+                            unsigned char flags);
 
   // For every matching event, a notification will be fired. NOTE: the
   // notification will fire for each matching event that has already occurred
   // since tracing was started (including before tracing if the process was
   // started with tracing turned on).
   void SetWatchEvent(const std::string& category_name,
                      const std::string& event_name);
   // Cancel the watch event. If tracing is enabled, this may race with the
   // watch event notification firing.
   void CancelWatchEvent();
@@ skipping 66 matching lines @@
                     const char* category,
                     const char* name,
                     int num_args,
                     const char** arg_names,
                     const unsigned char* arg_types,
                     const unsigned long long* arg_values);
   void AddClockSyncMetadataEvents();
   static void ApplyATraceEnabledFlag(unsigned char* category_enabled);
 #endif
 
+  int AddTraceEventInternal(NotificationHelper& notifier,
+                            TimeTicks timestamp,
+                            char phase,
+                            const unsigned char* category_enabled,
+                            const char* name,
+                            int thread_id,
+                            unsigned long long id,
+                            int num_args,
+                            const char** arg_names,
+                            const unsigned char* arg_types,
+                            const unsigned long long* arg_values,
+                            int threshold_begin_id,
+                            long long threshold,
+                            unsigned char flags);
+
   // TODO(nduca): switch to per-thread trace buffers to reduce thread
   // synchronization.
   // This lock protects TraceLog member accesses from arbitrary threads.
   Lock lock_;
   bool enabled_;
   NotificationCallback notification_callback_;
   std::vector<TraceEvent> logged_events_;
   std::vector<std::string> included_categories_;
   std::vector<std::string> excluded_categories_;
   bool dispatching_to_observer_list_;
@@ skipping 10 matching lines @@
   const unsigned char* watch_category_;
   std::string watch_event_name_;
 
   DISALLOW_COPY_AND_ASSIGN(TraceLog);
 };
 
 }  // namespace debug
 }  // namespace base
 
 #endif  // BASE_DEBUG_TRACE_EVENT_IMPL_H_