Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 11366089: cc: Remove all remaining use of WebCore Rect/Point/Size types from the compositor. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

cc: Remove all remaining use of WebCore Rect/Point/Size types from the compositor. This change removes all IntPoint/FloatRect/IntSize/etc from the compositor. There remains an indirect dependency on these types through the WebCore::Region class, which we wrap but need to replace. However, the wrapper there hides the WebCore types inside it, so there are now no references to the types from anywhere else in the compositor. I went back and forth on how to deal with scroll "positions". The name suggested that they should be Points, and that the deltas should be Vectors. However this lent itself to super awkward math at times. In the end, it was much cleaner to make all scroll "positions" into scroll "offsets" and represent everything as Vectors. Covered by existing tests; no change in behaviour. R=enne BUG=147395 Relanding: https://codereview.chromium.org/11367080/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166027

Patch Set 1 #

Patch Set 2 : Remove gyp entries for stubs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -852 lines) Patch
M cc/DEPS View 1 chunk +1 line, -16 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M cc/geometry.h View 2 chunks +64 lines, -2 lines 0 comments Download
M cc/input_handler.h View 3 chunks +5 lines, -7 lines 0 comments Download
M cc/layer.h View 4 chunks +7 lines, -8 lines 0 comments Download
M cc/layer.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M cc/layer_impl.h View 4 chunks +13 lines, -15 lines 0 comments Download
M cc/layer_impl.cc View 4 chunks +14 lines, -11 lines 0 comments Download
M cc/layer_impl_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M cc/layer_tree_host.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/layer_tree_host_client.h View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/layer_tree_host_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_common.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 20 chunks +21 lines, -21 lines 0 comments Download
M cc/layer_tree_host_impl.h View 7 chunks +11 lines, -12 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 23 chunks +75 lines, -74 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 49 chunks +99 lines, -98 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 26 chunks +103 lines, -102 lines 0 comments Download
M cc/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/math_util.h View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/math_util.cc View 2 chunks +17 lines, -10 lines 0 comments Download
M cc/math_util_unittest.cc View 3 chunks +18 lines, -17 lines 0 comments Download
M cc/page_scale_animation.h View 4 chunks +12 lines, -11 lines 0 comments Download
M cc/page_scale_animation.cc View 7 chunks +28 lines, -28 lines 0 comments Download
M cc/proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scrollbar_animation_controller.h View 3 chunks +7 lines, -10 lines 0 comments Download
M cc/scrollbar_animation_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/scrollbar_animation_controller_linear_fade.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scrollbar_animation_controller_linear_fade_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/scrollbar_geometry_fixed_thumb.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scrollbar_geometry_fixed_thumb.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scrollbar_layer_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M cc/single_thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/single_thread_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D cc/stubs/FloatPoint.h View 1 chunk +0 lines, -6 lines 0 comments Download
D cc/stubs/FloatSize.h View 1 chunk +0 lines, -6 lines 0 comments Download
D cc/stubs/IntPoint.h View 1 chunk +0 lines, -6 lines 0 comments Download
D cc/stubs/IntSize.h View 1 chunk +0 lines, -6 lines 0 comments Download
D cc/stubs/float_point.h View 1 chunk +0 lines, -58 lines 0 comments Download
D cc/stubs/float_size.h View 1 chunk +0 lines, -59 lines 0 comments Download
D cc/stubs/int_point.h View 1 chunk +0 lines, -47 lines 0 comments Download
D cc/stubs/int_size.h View 1 chunk +0 lines, -50 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/geometry_test_utils.h View 1 chunk +14 lines, -8 lines 0 comments Download
M cc/test/layer_tree_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/thread_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/thread_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_content_layer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_layer_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/compositor_bindings/web_to_ccinput_handler_adapter.cc View 4 chunks +3 lines, -6 lines 0 comments Download
D webkit/compositor_bindings/webcore_convert.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/compositor_bindings/webcore_convert.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
going to reland this, i missed removing the stubs files from cc.gyp
8 years, 1 month ago (2012-11-05 17:43:40 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-05 17:58:00 UTC) #2
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-05 18:02:58 UTC) #3
jamesr
lgtm
8 years, 1 month ago (2012-11-05 18:02:59 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-05 18:04:35 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698